Skip to content

Overdrive Items & Locations#114

Merged
Andrewki44 merged 18 commits intoffx-rcfrom
Overdrives
Mar 22, 2026
Merged

Overdrive Items & Locations#114
Andrewki44 merged 18 commits intoffx-rcfrom
Overdrives

Conversation

@Andrewki44
Copy link
Copy Markdown
Member

Resolves #5

Adds Overdrive locations for

  • Tidus
  • Auron
  • Kimahri
  • Wakka

Tidus's Overdrive requirements lowered to 10/20/40

Auron's locations are always on, as they are passive locations based on receiving Progressive Jecht's Sphere items.
Wakka's locations are dependent on the Blitzball minigame options.
Tidus & Kimahri have new options to enable/exclude their locations

Tidus logic is based on an average of 5 overdrives per combat region.
Therefore Blitz Ace location comes into logic when the player has 8 combat regions in-logic.

Kimahri's location logic is based on fiends within accessible regions.
I have also swapped the Biran & Yenke fight to logically require Kimahri in the party now, instead of forcing him in, so as to enforce Overdrive location logic

--
Added Overdrive items for

  • Tidus
  • Auron
  • Kimahri
  • Wakka
  • Seymour

Overdrive items are not progressive, and can be received in any order.
They are marked as progression items to ensure they are always placed in the item pool.

@Andrewki44 Andrewki44 requested a review from a team March 11, 2026 01:51
@Andrewki44 Andrewki44 marked this pull request as draft March 11, 2026 01:56
@Andrewki44 Andrewki44 linked an issue Mar 11, 2026 that may be closed by this pull request
21 tasks
@Andrewki44
Copy link
Copy Markdown
Member Author

Leaving in draft for the moment pending client PR being ready, incase anything has been missed.
Would still appreciate any reviews

@Omnises
Copy link
Copy Markdown
Member

Omnises commented Mar 11, 2026

yet more evidence we will need every enemy to be its own region smh smh

Omnises
Omnises previously approved these changes Mar 16, 2026
@Andrewki44 Andrewki44 requested a review from Rurusachi March 16, 2026 23:38
@Andrewki44 Andrewki44 marked this pull request as ready for review March 17, 2026 11:20
Copy link
Copy Markdown

@Rurusachi Rurusachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems fine

@Andrewki44 Andrewki44 requested a review from Rurusachi March 17, 2026 22:53
@Andrewki44
Copy link
Copy Markdown
Member Author

Identified logic issue with Tidus's overdrive locations during testing sync today.
CanReachMinimumRegionRule is not evaluating as intended

@Andrewki44
Copy link
Copy Markdown
Member Author

Andrewki44 commented Mar 19, 2026

Additionally, Seed Cannon logic should not require Kimahri in the party if you have Kilika due to the Ragora tutorial

@Andrewki44 Andrewki44 marked this pull request as draft March 19, 2026 13:44
@Andrewki44
Copy link
Copy Markdown
Member Author

Converted back to draft pending updates to CanReachMinimumRegionRule

@Andrewki44 Andrewki44 marked this pull request as ready for review March 20, 2026 06:33
@Andrewki44
Copy link
Copy Markdown
Member Author

Ready for review once more.
Updates to CanReachMinimumRegionRule & CanReachMinimumLocationRule have resolved logic issues in overdrives & arena.

Copy link
Copy Markdown

@Rurusachi Rurusachi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. I don't really understand the changes to CanReachMinimumRegionRule and CanReachMinimumLocationRule because I still haven't taken a proper look at RuleBuilder so I'm just going to assume it's correct.
I mentioned this on Discord before but just to mention it here as well: I would've preferred the overdrive locations ids to match the item ids but I'm not gonna ask you to change that since that's a bit troublesome with the logic. Please keep it in mind when adding locations/items in the future. I might change these myself at some point when I have time though

@Andrewki44 Andrewki44 merged commit d315f47 into ffx-rc Mar 22, 2026
19 of 20 checks passed
@Andrewki44 Andrewki44 deleted the Overdrives branch March 22, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Overdrive Items & Locations

4 participants