CMake: added Neon support #275
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this interesting and relevant for inclusion? |
|
I'd love to see this merged - then I could work on enabling neon for FFTW when included via vcpkg. vcpkg uses CMakeLists.txt instead of the configure script. |
|
This should be a quick thing to review, could it be considered? |
|
Please merge this, it's sorely missing |
|
Yes, this is a much needed feature. |
|
--2 year bump-- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small mistake in
CMakeLists.txtin the version number, now at3.3.10. And it adds preliminary Neon support. Neon should work but has not been extensively tested. The build assumes that the compiler has native Neon support, as is the case i.e. with cross-compiling for Android.