Switching on CNTVCT for ThunderX2 platform and setting some optimization options. #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…. Commented by now.
…ilation slow down.
…eduling flags, removed
aur-ml
changed the title
stevengj
reviewed
Sep 14, 2018
| AX_CHECK_COMPILER_FLAGS(-fsched-critical-path-heuristic, CFLAGS="$CFLAGS -fsched-critical-path-heuristic") | ||
| AX_CHECK_COMPILER_FLAGS(-fsel-sched-pipelining, CFLAGS="$CFLAGS -fsel-sched-pipelining") | ||
| AX_CHECK_COMPILER_FLAGS(-fselective-scheduling, CFLAGS="$CFLAGS -fselective-scheduling") | ||
| AX_CHECK_COMPILER_FLAGS(-ftrapping-math, CFLAGS="$CFLAGS -ftrapping-math") |
There was a problem hiding this comment.
Are all of these flags necessary for the performance improvements, or is it only one or two of them that really matters?
There was a problem hiding this comment.
Are all of these flags necessary for the performance improvements, or is it only one or two of them that really matters?
Among about a hundred of checked flags only those were left, that have statistically significant influence on performance for the target platform.
There was a problem hiding this comment.
Here are charts with several benchFFT tests for optimized vs default versions:
https://github.com/aur-ml/fftw3/wiki
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on ThunderX2 servers: the performance on 2^20 i-FFT problem (ib1048576) improves for about 20-25%.
The proposed changes does not influence other hardware architectures.