FEXCore/Profiler: Implement support for JIT float fallbacks #4336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Feb 11, 2025
With ASIMD this can be decently faster. With my microbenchmark this makes pcmpistri ~6% faster. With FEX-Emu#4336 this can be made even faster since the incoming data can stay in vector registers; Removing some overhead of umov.
Sonicadvance1
added a commit
to Sonicadvance1/FEX
that referenced
this pull request
Feb 11, 2025
With ASIMD this can be decently faster. With my microbenchmark this makes pcmpistri ~6% faster. With FEX-Emu#4336 this can be made even faster since the incoming data can stay in vector registers; Removing some overhead of umov.
Sonicadvance1
force-pushed
the
softfloat_stats
branch
2 times, most recently
from
8cb6032 to
5be1b0c
Compare
Based on FEX-Emu#4291 and FEX-Emu#4324. Ideally this gets merged at the same time so we can have Mangohud be on version 2 before giving them an upstream patch. Performance-wise this change falls within noise of my x87 microbench. This just lets us track the number of float fallbacks FEX does, letting us detect things like x87 fallbacks and how frequent they are, so we can detect if a game might be slow or stuttering because of these fallbacks.
Sonicadvance1
force-pushed
the
softfloat_stats
branch
from
5be1b0c to
39c1f81
Compare
lioncash
approved these changes
Feb 12, 2025
|
https://github.com/Sonicadvance1/MangoHud/tree/fex For the current mangohud implementation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4291 and #4324. Ideally this gets merged at the same time so
we can have Mangohud be on version 2 before giving them an upstream
patch.
Performance-wise this change falls within noise of my x87 microbench.
This just lets us track the number of float fallbacks FEX does, letting
us detect things like x87 fallbacks and how frequent they are, so we can
detect if a game might be slow or stuttering because of these fallbacks.