Open
Conversation
Define new variables to track tracer changes due to advection and diffusion. We want to save for now diffusion and advection contribution to the tracer changes. Horizontal and vertical diffusion includes Redi parametrization (if it is set .true.).
Fill __ciso directive to ensure that carbon isotope code works. Medusa interface is added.
Use __coccos in src/CMakeLists.txt to include 2 more phytoplankton classes FESOM2.6-REcoM setup with 4 phytoplankton, 3 zooplankton and 2 detritus functional types. BREAKING CHANGE: FESOM2.6-REcoM setup with 4p3z2d
Correct temperature function for small phytoplankton and diatoms. Previous update for the fouth phytoplankton class and new temperature functions for small phytoplankton and diatoms resulted in very low Phaeocystis biomass. We recognised that this is related to missing code lines in the temperature function which we correct with this update.
…ostics Use namelist.io to activate diagnostics. Sinking velocity of particle (fast and slow) are calculated but not written into a file before. We fix the missing diagnostics for sinking velocity of detritus classes. Besides we Extracted the K0, solubility which is computed in gasx.F90.
…esom2.6_recom_tra_diags
….6_recom_awiesm3_co2_coupling
Collaborator
Author
|
This branch still needs some cleanup. I very optimistically add it to 2.7 for now. |
The annual_event function incorrectly checked mod(yearnew, N) which tests divisibility of the absolute calendar year, not the elapsed simulation time. This caused restart_length to fail for multi-year runs when the calendar year was not divisible by the restart frequency. For example, with restart_length=2 starting in year 1900: - Old: writes restarts only in years 1900, 1902, 1904... (even years) - New: writes restarts after 1, 2, 3... elapsed years (1900, 1901, 1902...) Changes: - Added yearstart as module-level variable in g_clock - Modified annual_event to calculate elapsed_years = yearnew - yearstart + 1 - Now correctly triggers restart output every N simulation years regardless of starting calendar year This fix ensures restart_length works correctly for all frequencies (1, 2, 5, 10, 20, 50, etc.) and any starting year.
…ars' into fesom2.6_recom_awiesm3_co2_coupling
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not to be merge before: #802 is done.