Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve the world camera when switching to/from split view #6576

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Garanas
Copy link
Member

@Garanas Garanas commented Dec 5, 2024

Description of the proposed changes

Preserves the settings of the primary world camera when switching to/from split view.

Testing done on the proposed changes

Start up the game and switch to/from split view.

Additional context

split-screen.mp4

Checklist

  • Changes are annotated, including comments where useful
  • Changes are documented in the changelog for the next game version

@Garanas Garanas added the area: ui Anything to do with the User Interface of the Game label Dec 5, 2024
@Garanas
Copy link
Member Author

Garanas commented Dec 5, 2024

Mhh, some formatting got in too.

@Garanas Garanas marked this pull request as ready for review December 5, 2024 18:22
@Garanas
Copy link
Member Author

Garanas commented Dec 5, 2024

@BlackYps Small but nice change to include in the hotfix perhaps.

Copy link
Contributor

@lL1l1 lL1l1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual changes work and look good. I considered whether or not the right view's camera settings should preserved, but since it's not as persistent as the left view it doesn't need preservation (although an argument could be made for preference of left/right as the "main" view).

The formatting of long statements into multiline fragments is annoying (for me at least), maybe that could be changed in the repository's default vscode settings file, to more officially/consistently make it not happen? Currently some files have that formatting, while others don't. In particular I think the Prettier formatter doesn't like the blueprint file formatter, and conflicts on the format of sound blueprint tables.

changelog/snippets/features.6576.md Outdated Show resolved Hide resolved
@Garanas
Copy link
Member Author

Garanas commented Dec 9, 2024

The formatting of long statements into multiline fragments is annoying (for me at least), maybe that could be changed in the repository's default vscode settings file, to more officially/consistently make it not happen?

I agree, I think it is a small change to let prettier ignore it. I'd need to look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: ui Anything to do with the User Interface of the Game
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants