Tournament games

[1-alex98]

No description provided.

[1-alex98]

FAForever/server#675

[codecov]

Codecov Report

Merging #2807 (ab6e883) into develop (d6a9dd1) will decrease coverage by 0.48%.
The diff coverage is 32.63%.

❗ Current head ab6e883 differs from pull request most recent head 6aa418c. Consider uploading reports for the commit 6aa418c to get more accurate results

Additional details and impacted files

@@              Coverage Diff              @@
##             develop    #2807      +/-   ##
=============================================
- Coverage      65.50%   65.02%   -0.49%     
+ Complexity      5071     5002      -69     
=============================================
  Files            553      534      -19     
  Lines          20700    20752      +52     
  Branches        1159     1181      +22     
=============================================
- Hits           13559    13493      -66     
- Misses          6466     6585     +119     
+ Partials         675      674       -1     

Impacted Files	Coverage Δ
...forever/client/leaderboard/LeaderboardService.java	97.81% <0.00%> (-1.46%)	⬇️
...java/com/faforever/client/main/MainController.java	52.23% <0.00%> (+0.23%)	⬆️
...com/faforever/client/remote/FafServerAccessor.java	77.07% <0.00%> (-1.00%)	⬇️
...t/ui/preferences/GameDirectoryRequiredHandler.java	44.44% <0.00%> (ø)
.../client/ui/progress/RingProgressIndicatorSkin.java	0.00% <0.00%> (ø)
...er/client/ui/progress/ProgressCircleIndicator.java	23.52% <23.52%> (ø)
...ever/client/ui/progress/RingProgressIndicator.java	24.13% <24.13%> (ø)
...ver/client/notification/ImmediateNotification.java	54.16% <27.27%> (-19.17%)	⬇️
...ain/java/com/faforever/client/theme/UiService.java	39.43% <33.33%> (-0.41%)	⬇️
.../client/tournament/game/TournamentGameService.java	55.55% <55.55%> (ø)
... and 93 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 60752fc...6aa418c. Read the comment docs.

[Sheikah45]

Will have to see the indicator in action XD

[1-alex98]

Thx for the review should have addressed almost all of it. And commented the rest.

[Sheikah45]

Will look at this again soon

[Sheikah45]

Seems like it is in a pretty good state. Does this need any changes on the server?

[1-alex98]

Seems like it is in a pretty good state. Does this need any changes on the server?

yes but it will not hurt having it in the client before that is done