task1 is done #15
Open
task1 is done #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mighty-mhsl
approved these changes
Oct 29, 2023
|
|
||
| public void setName(String name) { | ||
| this.name = name; | ||
| } |
Contributor
There was a problem hiding this comment.
Если не используем, то можно и удалить в принципе
| // timeMachine.traveInTime(timeTraveler2, 1999); | ||
| // timeMachine.traveInTime(timeTraveler3, 2101); | ||
| // timeMachine.traveInTime(timeTraveler1, 2100); | ||
| } |
| timeMachine.traveInTime(timeTraveler1, 2000); | ||
| // timeMachine.traveInTime(timeTraveler2, 1999); | ||
| // timeMachine.traveInTime(timeTraveler3, 2101); | ||
| // timeMachine.traveInTime(timeTraveler1, 2100); |
Contributor
There was a problem hiding this comment.
Никогда не коммитим закомментированный код. Его всегда удаляем сразу
| TimeTraveler timeTraveler2 = new TimeTraveler("Ivan2", 2000, 2090); | ||
| TimeTraveler timeTraveler3 = new TimeTraveler("Ivan3", 1995, 2100); | ||
| TimeMachine timeMachine = new TimeMachine(); | ||
| timeMachine.isWorking=true; |
Contributor
There was a problem hiding this comment.
ctrl + alt + L в IDEA сделает автоформатирование
| throw new TimeTravelException("Machine is not working"); | ||
| } | ||
| if (year<timeTraveler.getBirthYear()) { | ||
| throw new TimeTravelException("Trave in year were traveler not birth"); |
Contributor
There was a problem hiding this comment.
Добавить контекст ошибки
| TimeTraveler timeTraveler3 = new TimeTraveler("Ivan3", 1995, 2100); | ||
| TimeMachine timeMachine = new TimeMachine(); | ||
| timeMachine.isWorking=true; | ||
| timeMachine.traveInTime(timeTraveler1, 2000); |
Contributor
There was a problem hiding this comment.
Обработки исключения не хватает
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Задача решена.