fix: scope refactor generation before planning fixes#1036
Merged
Conversation
chubes4
force-pushed
the
fix/refactor-generation-time-scoping
branch
from
ea42495 to
b843993
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
only/excludepolicy during audit fix generation instead of generating unrelated fixers and decompose plans firstapply_fix_policy()for final filtering, but make isolated repros truly isolated at generation timeWhy
Running:
homeboy refactor ... --from audit --only duplicate_function --writewas still generating unrelated decompose plans before policy filtering, which produced misleading conflict logs like
dominated by Decomposeand sent debugging in the wrong direction.After this change, the same isolated repro now touches only:
src/core/extension/grammar.rsinstead of building unrelated structural plans.
Validation
cargo build./target/debug/homeboy --output /tmp/homeboy-duplicate_function-repro-scoped.json refactor homeboy --path /var/lib/datamachine/workspace/homeboy-fixer-repro --from audit --only duplicate_function --force --write