Conversation
Homeboy Results —
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalizeTime(),inferDate(),mergePageVenueData()intoBaseExtractorshared methodsloadDom()helper to eliminate repeated 5-line DOM bootstrap boilerplate across 7+ extractorsfetchUrl()helper with logging for centralized HTTP fetch patternresolveUrl()helper for relative URL resolutionextractDateFromText()andparseTextDate()into one method usinginferDateFromMonthDay()Why
The universal web scraper has 24 extractors across ~9,600 lines. Multiple extractors had identical implementations of time normalization, year inference, venue merging, DOM loading, and URL resolution. This consolidation makes the codebase more maintainable and reduces the surface area for bugs as we add new extractors and scale venue coverage.
Net change
+191 lines (shared utilities), -171 lines (duplicated code) = net +20 lines