Skip to content

Fix tce-audio z-index mixed with absolute position issue #952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/5.0
Choose a base branch
from
Open

Fix tce-audio z-index mixed with absolute position issue #952

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c35f39
Fix tce-audio z-index mixed with absolute position issue
Jan 25, 2022
60619fa
Remove unnecessary template tag
Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/components/common/tce-core/PreviewOverlay.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<template functional>
<v-overlay
:value="props.show"
z-index="0"
opacity="0.9"
absolute>
<button class="message pa-2 grey--text text--lighten-2">
Expand Down
1 change: 0 additions & 1 deletion client/components/content-elements/tce-audio/edit/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,6 @@ export default {
justify-content: center;
position: relative;
min-height: 4.5rem;
z-index: 999;

::v-deep {
.element-placeholder {
Expand Down
29 changes: 11 additions & 18 deletions client/components/content-elements/tce-embed/edit/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,17 @@
icon="mdi-iframe"
active-placeholder="Use toolbar to enter the url"
active-icon="mdi-arrow-up" />
<div v-else>
<div class="content">
<preview-overlay :show="!isDisabled && !isFocused" />
<!-- Dragging iframes is not supported inside sortablejs container! -->
<iframe
v-if="!isDragged"
ref="frame"
:src="url"
frameborder="0"
sandbox="allow-forms allow-same-origin allow-scripts"
class="content">
</iframe>
</div>
<div v-else class="content">
<preview-overlay :show="!isDisabled && !isFocused" />
<!-- Dragging iframes is not supported inside sortablejs container! -->
<iframe
v-if="!isDragged"
ref="frame"
:src="url"
frameborder="0"
sandbox="allow-forms allow-same-origin allow-scripts"
class="content">
</iframe>
</div>
</div>
</template>
Expand Down Expand Up @@ -67,11 +65,6 @@ export default {
}

.content {
position: absolute;
top: 0;
right: 0;
bottom: 0;
left: 0;
width: 100%;
height: 100%;
}
Expand Down