Skip to content

Model.get_node() --> Model.get_node_or_null() #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PGComai wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Model.get_node() --> Model.get_node_or_null() #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Core/Main.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,7 @@ func load_vrm(path) -> bool:
var model = $ModelController.get_node_or_null("Model")
if model:
var secondary_path = NodePath("secondary") #model.vrm_secondary
var secondary = model.get_node(secondary_path)
var secondary = model.get_node_or_null(secondary_path)

#if collider_data == null:
# collider_data = []
Expand Down
2 changes: 1 addition & 1 deletion Core/ModelController.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ func get_skeleton() -> Skeleton3D:
return null

# Try to find the skeleton on the secondary object first.
var secondary = $Model.get_node("secondary")
var secondary = $Model.get_node_or_null("secondary")
if secondary:
if secondary is VRMSecondary:
var skeleton2 : Skeleton3D = secondary.get_node(secondary.skeleton)
Expand Down