Resolve non-noreply co-author emails in verifyPeerReview - #107
Merged
roryabraham merged 3 commits intoSep 9, 2026
Merged
Conversation
Co-authored-by trailers on bot commits don't always use a users.noreply.github.com address, e.g. `Co-authored-by: RachCHopkins <rachael@expensify.com>`. The check threw on the first such trailer, even when a second noreply trailer named the same person. Keep the noreply pattern as the fast path and fall back to the GraphQL Commit.authors connection, which GitHub resolves against every verified email on an account, including private ones. Emails GitHub can't match still fail the check.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8be8b66813
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
GraphQL Commit.authors returns at most 100 entries per page, so a co-author past the first page would have been reported as unresolved. Follow pageInfo cursors, capped at three pages so a pathological commit message can't turn into unbounded API requests.
roryabraham
requested changes
Sep 9, 2026
One page of 100 covers every real commit; note the limit in the doc comment.
roryabraham
approved these changes
Sep 9, 2026
roryabraham
deleted the
nicolas/verify-peer-review-resolve-non-noreply-coauthors
branch
September 9, 2026 23:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
getCommitAuthorsonly resolvedusers.noreply.github.comco-author emails, so a trailer likeCo-authored-by: RachCHopkins <rachael@expensify.com>threwUnresolved co-authorand failed the check.The noreply pattern stays as the fast path. For any other email, a new
getCommitAuthorLoginsByEmailhelper queries the GraphQLCommit.authorsconnection, which GitHub resolves against every verified email on an account, private ones included. Emails GitHub still can't match fail the check as before, so the security posture is unchanged.Related Issues
$ https://github.com/Expensify/Expensify/issues/680362
Manual Tests
Unit tests cover the noreply fast path, the GraphQL fallback, case-insensitive matching, and the unresolved-email failure.
Live check against the failing PR:
evaluatePeerReviewforExpensify/Integration-Server#9322with a real client andGITHUB_TOKENset.Resolved co-author email through GitHub commit authorsforrachael@expensify.com→RachCHopkins.passwith1/1 independent eligible reviewer approval(s).Linked PRs
N/A