Bundle peer review check as standalone Bun executable - #105
Closed
roryabraham wants to merge 4 commits into
Closed
roryabraham wants to merge 4 commits into
roryabraham wants to merge 4 commits into
Conversation
Contributor
Author
|
ok, so while this seems fine, the final binary is ~91MiB, which I'm assuming will take about 5-10s to download. So the premise doesn't really hold: this is more complexity for roughly a wash in execution time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
Migrates the peer-review verifier and this repository's TypeScript tooling from Node/tsx/npm to Bun. The verifyPeerReview script is compiled to a standalone Linux x64 executable, so that this workflow no longer has to setup node or install node_modules. It's expected that this will save 5-10s per workflow execution. In this run it took ~7s, and I'm assuming that downloading a single binary will be much faster.
The binary is published on merge via GitHub releases, and verified via GitHub's attestation feature.
Related Issues
$ https://github.com/Expensify/Expensify/issues/670058
Manual Tests
n/a - merge to test. Generally though, Bun has very high compatibility with node and built-in TS support.
Linked PRs
N/A