[No QA] Upgrade React Native to 0.66 #6914

roryabraham · 2021-12-28T21:15:12Z

Details

This pull request upgrades the following packages:

react-native: upgraded from 0.64.1 to 0.66.4
react-native-reanimated: upgraded from 2.3.0-alpha.1 to 2.3.1
- Upgraded because it fixes [RN 0.66] iOS build failure: 'boost/operators.hpp' file not found software-mansion/react-native-reanimated#2456
metro-react-native-babel-preset: upgraded from ^0.61.1 to ^0.66.2
- Did this as it was recommended by the React Native Upgrade Helper
react-native-config: upgraded from 1.4.0 to 1.4.5
- Was necessary to get Android to build
react-native-plaid-link-sdk: upgraded from 7.1.0 to 7.2.0
- Was necessary to get Android to build

And adds the react-native-clean-project as a dev dependency, along with a useful clean script. More details on all that does here. Note that we're using an alpha version because it fixed this issue for me.

Note: The React Native Upgrade Helper was used to guide some of these changes.

Note: We should follow-up with an issue to upgrade react-native-modal because it's throwing errors due to the deprecated removeEventListener function. This has been fixed in their latest version.

Note: We should also follow-up with an issue to upgrade urbanairship-react-native, because it's throwing warnings like new NativeEventEmitter() was called with a non-null argument without the required removeListeners method

Fixed Issues

Coming from #6898 (comment) and #6874 (comment)

Tests

(optional) Run npm run clean to clean the project
Install node modules and pods: npm i && cd ios && pod install && cd ..
Run the app
Run various basic regression tests to verify that the app is working as expected.

QA Steps

None, just regression testing.

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

parasharrajat · 2021-12-29T18:48:07Z

This is the correct time to upgrade the RN-web as well. We will fix a couple of issues along with this.

roryabraham · 2021-12-29T20:26:44Z

I was thinking we would upgrade RN first, then RN-web in a separate PR. Do you think we should do both in a single PR?

roryabraham · 2021-12-29T20:50:48Z

It actually looks like we're pointing at our fork, which is several commits ahead of the upstream react-native-web. So I'm not sure there's anything to upgrade there.

parasharrajat · 2021-12-29T21:08:37Z

Ok. Sounds great. Even if we had to. It should definitely be a separate PR.

roryabraham · 2021-12-30T14:29:04Z

I got Android working, but I'm seeing the following warning:

So we'll probably need to follow-up and update UrbanAirship. Going to want to do this in another separate PR.

roryabraham · 2021-12-30T14:39:27Z

I'm getting an infinite spinner trying to open the Plaid modal on Android. I wonder if I broke it or if I'm just holding something wrong for testing Plaid on dev. Would be best to get this working on dev, but I did double-check to verify that the Plaid bank account setup is covered by regression tests: https://expensify.slack.com/archives/C9YU7BX5M/p1640874804291700

parasharrajat · 2021-12-30T14:39:42Z

Yeah, and also refactor our app to use .remove instead of removeEventListners

roryabraham · 2021-12-30T14:40:46Z

Yeah, and also refactor our app to use .remove instead of removeEventListners

I think this PR does that. Some of our dependencies will need to be upgraded for all these warnings to go away.

roryabraham · 2021-12-30T14:54:25Z

Ahh, got Plaid working on Android. I needed a second ngrok tunnel for the web-secure API.

# Conflicts: # ios/Podfile.lock # package.json

roryabraham · 2022-01-04T16:58:13Z

Taking this out of draft

alex-mechler

Changes look good to me, but I'm not super familiar with the gradle changes. Do you know someone else who is and can double check them?

roryabraham · 2022-01-04T23:05:35Z

Tagging in @Julesssss for.a second review.

alex-mechler

All you Jules

roryabraham · 2022-01-05T16:14:35Z

Regarding the Android build failure, @Julesssss did you try running npm run clean?

roryabraham · 2022-01-05T16:15:38Z

Or at minimum, rm -rf node_modules && npm i (because it looks like the error is coming from a node module which may have been cached from an out-of-date version

Julesssss · 2022-01-05T17:28:14Z

I tried npm run clean, but didn't completely clear node_modules. Will give that a try tomorrow.

alex-mechler

Haven't been able to get android / ios to build, but I usually have to struggle to get those to build on my machine. @Julesssss feel free to merge if you can get both of those building for you

Julesssss · 2022-01-06T14:13:43Z

Or at minimum, rm -rf node_modules && npm i (because it looks like the error is coming from a node module which may have been cached from an out-of-date version

Wiping node_modules resolved the Android terminal issue. I struggled to build iOS from the terminal, but I'm pretty sure it's an issue with my local env as I was able to build from XCode. Merging!

Julesssss · 2022-01-06T14:54:23Z

Actually, while I can build to iOS, I have been unable to fully verify iOS.

When building to a physical device I get a connection error, and with simulator, I get an immidiate dyld crash (seems to be related to the RCTTextHeaders library).

roryabraham · 2022-01-06T14:54:43Z

@Julesssss since you said "Merging!" I assumed you had just forgotten to merge this 😬

roryabraham · 2022-01-06T14:54:57Z

Bad timing on my part...

OSBotify · 2022-01-06T14:55:11Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Julesssss · 2022-01-06T14:55:15Z

Yeah... my fault. I started debugging and hadn't yet sent the above message

Julesssss · 2022-01-06T14:55:44Z

Have you been able to verify iOS? If so I'm less worried as it seems to be issues on my end only.

roryabraham · 2022-01-06T14:56:05Z

Well it's not deployed yet. I had no issues building to a simulator, logging in, etc..., but I admittedly did not test with a physical device. Let me try that next

Julesssss · 2022-01-06T14:57:15Z

If you can log in with a physical device and simulator I think we're fine. I don't want to spend too much longer debugging this but will spend another 10 mins or so

Julesssss · 2022-01-06T15:12:52Z

@roryabraham okay, I finally got it to work on an iOS simulator. Not exactly sure why, but after retargeting iOS 12 in XCode and a bunch of other things it works. It must have been something on my side.

roryabraham · 2022-01-06T15:13:47Z

Thanks for working through it @Julesssss. I'm still going to try and run the app on a physical device

roryabraham · 2022-01-06T16:06:41Z

Yeah, everything worked on a physical device too. As stated in Slack, I've had to build from XCode once and then everything starts working normally from the CLI

OSBotify · 2022-01-10T19:45:40Z

🚀 Deployed to staging by @roryabraham in version: 1.1.26-2 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2022-01-10T20:02:12Z

🚀 Deployed to staging by @roryabraham in version: 1.1.27-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-01-12T05:04:38Z

🚀 Deployed to production by @roryabraham in version: 1.1.27-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

roryabraham added 2 commits December 28, 2021 15:22

Upgrade react-native, clean project, add clean script

ee59735

Update react-native-reanimated

e2651b7

roryabraham self-assigned this Dec 28, 2021

roryabraham mentioned this pull request Dec 28, 2021

fix: New chat aren't showing bold in Left Hand Nav #6898

Merged

5 tasks

roryabraham added 4 commits December 28, 2021 16:48

Remove deprecated Dimensions.removeEventListener usages

9ffd04f

Update android build settings

bdb89ae

Update metro-react-native-babel-preset

440e074

Apply XCode 12.5 M1 post install workaround

c5e59ef

Upgrade react-native-config and plaid to get android to build

f235f90

roryabraham added 3 commits December 30, 2021 10:02

Update pods again

31c73d8

Merge branch 'main' into Rory-UpgradeRN

c175646

# Conflicts: # ios/Podfile.lock # package.json

Reinstall pods after resolving merge conflicts

41025e1

roryabraham marked this pull request as ready for review January 4, 2022 16:57

roryabraham requested a review from a team as a code owner January 4, 2022 16:57

MelvinBot requested review from alex-mechler and removed request for a team January 4, 2022 16:58

alex-mechler reviewed Jan 4, 2022

View reviewed changes

roryabraham requested a review from Julesssss January 4, 2022 23:05

alex-mechler previously approved these changes Jan 4, 2022

View reviewed changes

roryabraham dismissed alex-mechler’s stale review via 6c8ef70 January 5, 2022 16:11

roryabraham requested a review from Julesssss January 5, 2022 16:14

Julesssss approved these changes Jan 5, 2022

View reviewed changes

alex-mechler approved these changes Jan 6, 2022

View reviewed changes

roryabraham merged commit 021ad5d into main Jan 6, 2022

roryabraham deleted the Rory-UpgradeRN branch January 6, 2022 14:54

roryabraham mentioned this pull request Jan 6, 2022

[No QA] Reinstall pods #7062

Merged

Jag96 mentioned this pull request Jan 6, 2022

IOU- Console error displayed when Split/Request Money #7063

Closed

OSBotify mentioned this pull request Jan 10, 2022

Deploy Checklist: New Expensify 2022-01-10 #7108

Closed

24 tasks

This was referenced Jan 13, 2022

[Tracking] Deprecate jCenter in build.gradle #7190

Closed

[No QA] Add jcenter back to build.gradle #7191

Merged

rushatgabhane mentioned this pull request Jan 20, 2022

[HOLD for payment 2022-02-08] Web - JS Console error appears when clicking user name #7293

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[No QA] Upgrade React Native to 0.66 #6914

[No QA] Upgrade React Native to 0.66 #6914

roryabraham commented Dec 28, 2021 •

edited

Loading

parasharrajat commented Dec 29, 2021

roryabraham commented Dec 29, 2021

roryabraham commented Dec 29, 2021

parasharrajat commented Dec 29, 2021

roryabraham commented Dec 30, 2021 •

edited

Loading

roryabraham commented Dec 30, 2021 •

edited

Loading

parasharrajat commented Dec 30, 2021 •

edited

Loading

roryabraham commented Dec 30, 2021

roryabraham commented Dec 30, 2021

roryabraham commented Jan 4, 2022

alex-mechler left a comment •

edited

Loading

roryabraham commented Jan 4, 2022

alex-mechler left a comment

roryabraham commented Jan 5, 2022

roryabraham commented Jan 5, 2022

Julesssss commented Jan 5, 2022

alex-mechler left a comment

Julesssss commented Jan 6, 2022

Julesssss commented Jan 6, 2022

roryabraham commented Jan 6, 2022

roryabraham commented Jan 6, 2022

OSBotify commented Jan 6, 2022

Julesssss commented Jan 6, 2022 •

edited

Loading

Julesssss commented Jan 6, 2022

roryabraham commented Jan 6, 2022 •

edited

Loading

Julesssss commented Jan 6, 2022 •

edited

Loading

Julesssss commented Jan 6, 2022

roryabraham commented Jan 6, 2022

roryabraham commented Jan 6, 2022

OSBotify commented Jan 10, 2022

OSBotify commented Jan 10, 2022

OSBotify commented Jan 12, 2022

[No QA] Upgrade React Native to 0.66 #6914

[No QA] Upgrade React Native to 0.66 #6914

Conversation

roryabraham commented Dec 28, 2021 • edited Loading

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

parasharrajat commented Dec 29, 2021

roryabraham commented Dec 29, 2021

roryabraham commented Dec 29, 2021

parasharrajat commented Dec 29, 2021

roryabraham commented Dec 30, 2021 • edited Loading

roryabraham commented Dec 30, 2021 • edited Loading

parasharrajat commented Dec 30, 2021 • edited Loading

roryabraham commented Dec 30, 2021

roryabraham commented Dec 30, 2021

roryabraham commented Jan 4, 2022

alex-mechler left a comment • edited Loading

Choose a reason for hiding this comment

roryabraham commented Jan 4, 2022

alex-mechler left a comment

Choose a reason for hiding this comment

roryabraham commented Jan 5, 2022

roryabraham commented Jan 5, 2022

Julesssss commented Jan 5, 2022

alex-mechler left a comment

Choose a reason for hiding this comment

Julesssss commented Jan 6, 2022

Julesssss commented Jan 6, 2022

roryabraham commented Jan 6, 2022

roryabraham commented Jan 6, 2022

OSBotify commented Jan 6, 2022

Julesssss commented Jan 6, 2022 • edited Loading

Julesssss commented Jan 6, 2022

roryabraham commented Jan 6, 2022 • edited Loading

Julesssss commented Jan 6, 2022 • edited Loading

Julesssss commented Jan 6, 2022

roryabraham commented Jan 6, 2022

roryabraham commented Jan 6, 2022

OSBotify commented Jan 10, 2022

OSBotify commented Jan 10, 2022

OSBotify commented Jan 12, 2022

roryabraham commented Dec 28, 2021 •

edited

Loading

roryabraham commented Dec 30, 2021 •

edited

Loading

roryabraham commented Dec 30, 2021 •

edited

Loading

parasharrajat commented Dec 30, 2021 •

edited

Loading

alex-mechler left a comment •

edited

Loading

Julesssss commented Jan 6, 2022 •

edited

Loading

roryabraham commented Jan 6, 2022 •

edited

Loading

Julesssss commented Jan 6, 2022 •

edited

Loading