Skip to content

Add label as optional arg to @override directive #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Samjin
Copy link

@Samjin Samjin commented Apr 14, 2025

Add support for 2nd argument label for progressive @override directive.
Support federation v2.7.

@dariuszkuc
Copy link
Collaborator

Currently this lib allows you specify you own custom @link federation spec import -> this change does not account for this and will update directive definitions even if folks specifically target older versions of federation

@Samjin Samjin marked this pull request as draft April 14, 2025 18:11
@Samjin
Copy link
Author

Samjin commented Apr 14, 2025

Currently this lib allows you specify you own custom @link federation spec import -> this change does not account for this and will update directive definitions even if folks specifically target older versions of federation

Had a brief discussion, the plan is to check if progressive override label would work with older fed version from composition. if not, we'll have to check fed version per directives to make sure they are correctly generated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants