Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP 8 order parameter fix and the arrival_date payout option is removed #15

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

PHP 8 order parameter fix and the arrival_date payout option is removed #15

wants to merge 3 commits into from

Conversation

asanovr
Copy link

@asanovr asanovr commented Oct 8, 2021 •
edited
Loading

  1. The $amount parameter for reverse transfer can be null by default and is not required PHP8 deprecating warning #10
  2. The arrival_date parameter is not needed to create a payout https://stripe.com/docs/api/payouts/create
  3. Missing brace is fixed

@asanovr
Copy link
Author

asanovr commented Oct 24, 2021

@ExpDev07

@MariusSpring
Copy link
Contributor

Hey! Wouldn't this be a breaking change? To insert a new parameter between other params? @asanovr

@asanovr
Copy link
Author

asanovr commented Nov 12, 2021

@MariusTechweb Hi!, Yeah! I removed only one argument in the payoutStripeAccount method, it doesn't work anyway, I tested it a few weeks ago

@oleg-kolzhanov
Copy link
Contributor

Hey! Wouldn't this be a breaking change? To insert a new parameter between other params? @asanovr

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleg-kolzhanov oleg-kolzhanov oleg-kolzhanov approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asanovr @MariusSpring @oleg-kolzhanov