-
-
Notifications
You must be signed in to change notification settings - Fork 321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use shared Redis cache for jhu data #306
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avoids confusion between datetime module and and datetime object
move some messages to debug level log process id for location get not category get
debug is `10`
Detailed logging
Aio files
Kilo59
added
down
Related to API availability
source: jhu
enhancement
New feature or request
labels
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #304
Formerly all
gunicorn
workers would have to independently make HTTP requests to the various data sources. This is very inefficient and the problem is compounded when an error pulling from one data source occurs, causing a working timeout, a new worker process to be started up and all caches have to be from scratch.This PR uses
redis
to be used as a shared cache for alljhu
data. It falls back to an in-memory cache ifredis
is not available at startup.Other changes
pylint
config to `pyproject.tomalpydantic
for config managementFuture improvements
redis
fornyt
,csbs
dataredis
or in-memory fallback.redis
containerredis
connection handling and pool management