Basis for providing multiple data-sources. #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is some groundwork for providing multiple data-sources (#114). To use, simply add
?source=your_source_of_choiceat the end of your requests: For example:http GET /v2/locations?source=jhuHow it works
At the moment, the only available source is still
jhu, however, this adds the basis for providing more. This is possible through a middleware that gets executed before every request, dynamically retrieving the service responsible for the source by looking at the query parametersourceand attaches it to the request (available throughrequest.source). Defaults tojhuif omitted.Related
This allows for finally implementing features/fixes mentioned in issues such as #113, #111, #108, and #22.