Fix AuraHelper desync #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in the picture, the entity in GalleryCollab heartside has RNG, so this PR aims to fix it
(I've contacted AuraHelper's author and he says he will not udpate AuraHelper recently, so there's no worry that we need to revert this commit shortly after)
btw maybe this line of code
typeof(Entity).GetMethod("Update").HookAfter(AfterEntityUpdate);can be changed to hook on
Scene.AfterUpdateinstead, but this may cause some existing tases to desync