-
Notifications
You must be signed in to change notification settings - Fork 64
Add Detailed Daily Conference Schedule #1323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nikoshell
wants to merge
3
commits into
ep2025
Choose a base branch
from
ep2025-week-days
base: ep2025
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,42 @@ | ||||||
--- | ||||||
import Section from "@ui/Section.astro"; | ||||||
import Button from "@ui/Button.astro"; | ||||||
import Headline from "@ui/Headline.astro"; | ||||||
const schedule = [ | ||||||
{ dayname: 'Monday', day:'July 14', href: '/schedule/day/2025-07-14' }, | ||||||
{ dayname: 'Tuesday', day:'July 15', href: '/schedule/day/2025-07-15' }, | ||||||
{ dayname: 'Wednesday', day:'July 16', href: '/schedule/day/2025-07-16' }, | ||||||
{ dayname: 'Thursday', day:'July 17', href: '/schedule/day/2025-07-17' }, | ||||||
{ dayname: 'Friday', day:'July 18', href: '/schedule/day/2025-07-18' }, | ||||||
]; | ||||||
|
||||||
const sprints = { | ||||||
day: 'July 19–20', | ||||||
dayname: 'Sprints', | ||||||
href: '/sprints', | ||||||
}; | ||||||
--- | ||||||
|
||||||
<Section> | ||||||
<Headline as="h5" title="Detailed Daily Conference Schedule" center="true" /> | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This can be more concise -- we can see its daily, and nearly everything on this site relates to the conference:
Suggested change
|
||||||
<div class="schedule-grid p-2"> | ||||||
{schedule.map(day => ( | ||||||
<Button url={day.href} outline class="schedule-box"> | ||||||
{day.day}<br />{day.dayname} | ||||||
</Button> | ||||||
))} | ||||||
|
||||||
<Button url={sprints.href} secondary class="schedule-box"> | ||||||
{sprints.day}<br />{sprints.dayname} | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||||||
</Button> | ||||||
</div> | ||||||
</Section> | ||||||
|
||||||
<style> | ||||||
.schedule-grid { | ||||||
display: grid; | ||||||
grid-template-columns: repeat(auto-fit, minmax(140px, 1fr)); | ||||||
gap: 1rem; | ||||||
margin-top: 1rem; | ||||||
} | ||||||
</style> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are sprints active? I think it's the most boring part of the conference so I'd either
wdyt?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd remove the highlight, or preferably highlight the current day during the conference (which could be a separate PR).
It also sticks out as "Sprints" and not day names ("Saturday-Sunday"), compared to the others which don't tell you what's happening.
Either use day names for all, or day names plus content for all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, let's use
Saturday & Sunday
- content is in the section above, so I would not repeat it