Feature/footer#3
Open
Eugod wants to merge 3 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
Adds a footer feature to the portfolio app, including reusable footer-related sections and updated layout wiring.
Changes:
- Adds
Footer,Logo, andContactIconcomponents with CSS modules. - Renders the footer on the home page and updates header import paths/styles.
- Removes unused default public SVG assets.
Reviewed changes
Copilot reviewed 7 out of 18 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
public/window.svg |
Removes unused starter SVG asset. |
public/vercel.svg |
Removes unused starter SVG asset. |
public/next.svg |
Removes unused starter SVG asset. |
public/globe.svg |
Removes unused starter SVG asset. |
public/file.svg |
Removes unused starter SVG asset. |
components/sections/Logo/Logo.tsx |
Adds reusable linked logo component. |
components/sections/ContactIcon/ContactIcon.tsx |
Adds reusable contact icon link component. |
components/sections/ContactIcon/contactIcon.module.css |
Adds styles for contact icon links/images. |
components/pages/home/Home.tsx |
Imports and renders the footer on the home page. |
components/layouts/Header/Header.tsx |
Updates section import paths. |
components/layouts/Header/header.module.css |
Adds header layout styling. |
components/layouts/Footer/Footer.tsx |
Adds footer markup with logo, description, contacts, and copyright. |
components/layouts/Footer/footer.module.css |
Adds responsive footer styling. |
components/layouts/Footer.tsx |
No diff content provided; path appears absent in the current tree. |
Comments suppressed due to low confidence (5)
components/sections/ContactIcon/ContactIcon.tsx:10
- Links that open a new tab should set
rel="noopener noreferrer"to prevent the opened page from being able to access the original window viawindow.opener. Add the rel attribute here, or make it conditional if this component also needs to support non-blank targets later.
<Link
href={link}
target="_blank"
className={style.contactIconLink}
components/layouts/Footer/Footer.tsx:38
- The footer renders a hard-coded 2025 copyright year, which is stale for the current 2026 release date. This will display inaccurate site metadata unless it is updated or derived dynamically.
<p className={style.footerCopyright}>
© 2025 Eugenio Rodrigues. All rights reserved.
</p>
components/sections/Logo/Logo.tsx:10
- Because this image is the only content inside the link, its alt text becomes the link's accessible name.
Logois ambiguous and does not tell screen-reader users which site/home page the link opens; use the site or owner name and/or indicate it links home.
src="/logo.png"
alt="Logo"
width={150}
components/sections/Logo/Logo.tsx:12
- This component is currently used in the footer, so forcing the image to load eagerly can make a below-the-fold asset compete with critical page resources. Prefer the default lazy loading here, or make eager/priority loading configurable for above-the-fold usages such as the header.
loading="eager"
components/layouts/Footer/Footer.tsx:31
- This
mailto:link is rendered throughContactIcon, which hard-codestarget="_blank". Email links generally should not open a new browsing tab, because that can leave users with an extra blank tab or unexpected navigation; make the target configurable or omit it for mail links.
iconSrc="/email-icon.png"
altText="Email"
link="mailto:eugenio28.04@gmail.com"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+4
to
+12
| export const Logo = () => { | ||
| return ( | ||
| <Link href="/"> | ||
| <Image | ||
| src="/logo.png" | ||
| alt="Logo" | ||
| width={150} | ||
| height={40} | ||
| loading="eager" |
Comment on lines
+3
to
+17
| import style from "./contactIcon.module.css" | ||
|
|
||
| export const ContactIcon = ({ iconSrc, altText, link }: { iconSrc: string, altText: string, link: string }) => { | ||
| return ( | ||
| <Link | ||
| href={link} | ||
| target="_blank" | ||
| className={style.contactIconLink} | ||
| > | ||
| <Image | ||
| src={iconSrc} | ||
| alt={altText} | ||
| width={30} | ||
| height={30} | ||
| className={style.contactIconImage} |
| @@ -0,0 +1,42 @@ | |||
| import { Logo } from "../../sections/Logo/Logo" | |||
| import { ContactIcon } from "../../sections/ContactIcon/ContactIcon" | |||
| import style from "./footer.module.css" | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.