Skip to content

Feature/footer#3

Open
Eugod wants to merge 3 commits into
developfrom
feature/footer
Open

Feature/footer#3
Eugod wants to merge 3 commits into
developfrom
feature/footer

Conversation

@Eugod
Copy link
Copy Markdown
Owner

@Eugod Eugod commented May 13, 2026

No description provided.

@Eugod Eugod requested a review from Copilot May 13, 2026 22:30
@vercel
Copy link
Copy Markdown

vercel Bot commented May 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
projeto-portifolio Error Error May 13, 2026 10:30pm

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a footer feature to the portfolio app, including reusable footer-related sections and updated layout wiring.

Changes:

  • Adds Footer, Logo, and ContactIcon components with CSS modules.
  • Renders the footer on the home page and updates header import paths/styles.
  • Removes unused default public SVG assets.

Reviewed changes

Copilot reviewed 7 out of 18 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
public/window.svg Removes unused starter SVG asset.
public/vercel.svg Removes unused starter SVG asset.
public/next.svg Removes unused starter SVG asset.
public/globe.svg Removes unused starter SVG asset.
public/file.svg Removes unused starter SVG asset.
components/sections/Logo/Logo.tsx Adds reusable linked logo component.
components/sections/ContactIcon/ContactIcon.tsx Adds reusable contact icon link component.
components/sections/ContactIcon/contactIcon.module.css Adds styles for contact icon links/images.
components/pages/home/Home.tsx Imports and renders the footer on the home page.
components/layouts/Header/Header.tsx Updates section import paths.
components/layouts/Header/header.module.css Adds header layout styling.
components/layouts/Footer/Footer.tsx Adds footer markup with logo, description, contacts, and copyright.
components/layouts/Footer/footer.module.css Adds responsive footer styling.
components/layouts/Footer.tsx No diff content provided; path appears absent in the current tree.
Comments suppressed due to low confidence (5)

components/sections/ContactIcon/ContactIcon.tsx:10

  • Links that open a new tab should set rel="noopener noreferrer" to prevent the opened page from being able to access the original window via window.opener. Add the rel attribute here, or make it conditional if this component also needs to support non-blank targets later.
        <Link
            href={link}
            target="_blank"
            className={style.contactIconLink}

components/layouts/Footer/Footer.tsx:38

  • The footer renders a hard-coded 2025 copyright year, which is stale for the current 2026 release date. This will display inaccurate site metadata unless it is updated or derived dynamically.
                <p className={style.footerCopyright}>
                    © 2025 Eugenio Rodrigues. All rights reserved.
                </p>

components/sections/Logo/Logo.tsx:10

  • Because this image is the only content inside the link, its alt text becomes the link's accessible name. Logo is ambiguous and does not tell screen-reader users which site/home page the link opens; use the site or owner name and/or indicate it links home.
                src="/logo.png"
                alt="Logo"
                width={150}

components/sections/Logo/Logo.tsx:12

  • This component is currently used in the footer, so forcing the image to load eagerly can make a below-the-fold asset compete with critical page resources. Prefer the default lazy loading here, or make eager/priority loading configurable for above-the-fold usages such as the header.
                loading="eager"

components/layouts/Footer/Footer.tsx:31

  • This mailto: link is rendered through ContactIcon, which hard-codes target="_blank". Email links generally should not open a new browsing tab, because that can leave users with an extra blank tab or unexpected navigation; make the target configurable or omit it for mail links.
                            iconSrc="/email-icon.png"
                            altText="Email"
                            link="mailto:eugenio28.04@gmail.com"

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread components/sections/ContactIcon/contactIcon.module.css
Comment on lines +4 to +12
export const Logo = () => {
return (
<Link href="/">
<Image
src="/logo.png"
alt="Logo"
width={150}
height={40}
loading="eager"
Comment on lines +3 to +17
import style from "./contactIcon.module.css"

export const ContactIcon = ({ iconSrc, altText, link }: { iconSrc: string, altText: string, link: string }) => {
return (
<Link
href={link}
target="_blank"
className={style.contactIconLink}
>
<Image
src={iconSrc}
alt={altText}
width={30}
height={30}
className={style.contactIconImage}
@@ -0,0 +1,42 @@
import { Logo } from "../../sections/Logo/Logo"
import { ContactIcon } from "../../sections/ContactIcon/ContactIcon"
import style from "./footer.module.css"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants