Fix active Zig 0.16 Walk map type#4
Conversation
|
@coderabbitai review |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
📝 WalkthroughSummary by CodeRabbit
WalkthroughTwo global variables in ChangesWalk Map Type Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a Zig 0.16 build break in src/Walk.zig by replacing the removed std.array_hash_map.String(...) alias with the supported std.StringArrayHashMapUnmanaged(...), preserving the existing .empty initialization and allocator-explicit deinit/put usage patterns used across the codebase.
Changes:
- Replace
std.array_hash_map.String(File)withstd.StringArrayHashMapUnmanaged(File)forWalk.files. - Replace
std.array_hash_map.String(File.Index)withstd.StringArrayHashMapUnmanaged(File.Index)forWalk.modules.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@coderabbitai review |
✅ Action performedReview finished.
|
Code Review Roast 🔥Verdict: No Issues Found | Recommendation: Merge Oh wait, this PR is actually clean. I need to sit down. I had my flamethrower warmed up and everything. 📊 Overall: Like finding a unicorn in production — I didn't think clean PRs existed anymore, but here we are. Files Reviewed (1 file)
Reviewed by nex-n2-pro:free · 703,634 tokens |
Summary
Reproduced failure on origin/main
Active toolchain: zig 0.16.0-dev.3142+5ccfeb926.
origin/main at 88744f5 fails:
Validation
E2E
Installed zigdoc into /private/tmp/zigdoc-e2e.ibPyBr/prefix and tested:
Notes