Add custom event classes for lockers, parcels, users, and item storage

[Jakubk15]

Introduced new cancellable and non-cancellable event classes for locker creation/deletion, parcel send/deliver/collect, user creation/name change, and item storage updates. Also fixed a message key in DeliveryManager from 'deletedContents' to 'deletedDeliveries' for admin notifications.

[gemini-code-assist]

Summary of Changes

Hello @Jakubk15, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the extensibility of the application by introducing a comprehensive set of custom event classes across key domains: lockers, parcels, users, and item storage. These events, many of which are cancellable, provide external modules and developers with robust hooks to interact with and potentially modify core system behaviors. Additionally, a minor correction was made to an admin notification message key for improved clarity.

Highlights

• New Event Classes: Introduced a comprehensive set of new custom event classes for various core functionalities including locker creation/deletion, parcel sending/delivering/collecting, user creation/name changes, and item storage updates.
• Cancellable Events: Many of the newly added events (for lockers, parcels, and item storage) are cancellable, allowing external plugins or modules to prevent actions from occurring.
• Non-Cancellable Events: Events related to user creation and name changes are non-cancellable, providing notification without allowing modification of the action.
• Message Key Fix: Corrected a message key in the DeliveryManager from 'deletedContents' to 'deletedDeliveries' for improved clarity in admin notifications.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Jakubk15]

@copilot I would like you to go through the code and fire the event classes added in this branch in the appropriate sections of the code, e.g. fire LockerCreateEvent on Locker creation.

[Copilot]

@Jakubk15 I've opened a new pull request, #161, to work on those changes. Once the pull request is ready, I'll request review from you.

[gemini-code-assist]

Code Review

This pull request introduces a suite of new event classes for various domain actions, which is a great step towards making the plugin more extensible. The change also includes a small but important fix for a message key. My review focuses on improving consistency and maintainability across these new event classes. I've pointed out some inconsistencies in annotations and event asynchronicity. Additionally, I've suggested a way to reduce boilerplate code for cancellable events by using an abstract base class. These changes should help improve the overall code quality.

[gemini-code-assist]

This event is marked as asynchronous by calling super(true) in the constructor. This is inconsistent with other new cancellable events in this pull request, which are synchronous by default. If this event is not intended to be fired and handled asynchronously, this call should be removed to prevent potential concurrency issues, such as illegal cross-thread API access. If it is intentional, it would be good to add a comment explaining why this specific event is async.

    public ParcelDeliverEvent(Parcel parcel) {
        this.parcel = parcel;
    }