Refactor and enhance scheduler, GitHub review, and guild stats.

[vLuckyyy]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @vLuckyyy, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces substantial architectural improvements to the application's core, focusing on better component management, robust scheduling, and enhanced GitHub review processes. It also refines the auto-messaging and guild statistics features, making them more reliable and configurable. The changes aim to improve maintainability, performance, and overall stability.

Highlights

• Core Architecture Refactor: The main DiscordApp class has been significantly refactored to centralize component management using an ApplicationComponents inner class. This improves dependency handling, streamlines the application startup process, and enhances graceful shutdown procedures by moving away from static global state.
• Enhanced Scheduler Implementation: The VirtualThreadSchedulerImpl has undergone a major overhaul. It now leverages separate ScheduledExecutorService and ExecutorService instances, providing more precise control over task scheduling and execution on virtual threads. This includes robust shutdown logic with explicit termination waits and improved logging for task lifecycle.
• Improved Auto-Messaging System: The auto-messaging feature is now more flexible and robust. It utilizes a new AutoMessagesConfig for dedicated configuration, supports sending random messages from a list of variants per channel, and includes smarter duplicate message detection to prevent spam.
• GitHub Review Reminder Logic: The GitHub review reminder service has been enhanced to prevent sending redundant reminders. Before notifying a reviewer, the system now checks the GitHub API to confirm if the user has already submitted a review for the pull request.
• Guild Statistics Reliability: The process for updating guild statistics (e.g., member counts in voice channel names) has been made more reliable. It now operates asynchronously with improved error handling, ensuring more consistent updates to Discord channel names.
• Removed User Persistence Layer: The entire user persistence layer, including User, UserRepository, UserRepositoryImpl, and UserWrapper classes, has been removed. This indicates a significant change in how user data is managed or stored within the application.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a significant and valuable refactoring of the application's core lifecycle, dependency management, and several key features. The move to an instance-based DiscordApp with an ApplicationComponents holder is a major step forward for maintainability and testability. The enhancements to the scheduler, auto-messages, and guild statistics using asynchronous patterns and improved error handling are also excellent.

However, I've identified a few critical issues that will prevent the application from compiling, primarily related to the removal of the user repository and an unhandled exception in the new scheduler's shutdown sequence. I've also noted a potential logic change in the message filter and an area of unnecessary complexity in the scheduler implementation that could be simplified.

Once the critical issues are addressed, this will be a very strong contribution to the project.