Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applications/V7/cmd/dc fixes #1142

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Applications/V7/cmd/dc fixes #1142

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
984f056
dc: fix off-by-one initialising symlst[]
Jan 23, 2025
9cafebe
dc: explicitly declare signed char for number buffers
Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions Applications/V7/cmd/dc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,10 +45,10 @@
#define errorrt(p) {printf(p); return NULL; }

struct blk {
char *rd;
char *wt;
char *beg;
char *last;
signed char *rd;
signed char *wt;
signed char *beg;
signed char *last;
};
struct sym {
struct sym *next;
Expand Down Expand Up @@ -145,8 +145,8 @@ void (*outdit) (struct blk *, int);
int logo;
int intlog10;
int count;
char *pp;
char *dummy;
signed char *pp;
signed char *dummy;

int main(int argc, char *argv[])
{
Expand Down Expand Up @@ -1123,7 +1123,7 @@ void init(int argc, char *argv[])
readptr = &readstk[0];
k = 0;
sp = sptr = &symlst[0];
while (sptr < &symlst[TBLSZ]) {
while (sptr < &symlst[TBLSZ-1]) {
sptr->next = ++sp;
sptr++;
}
Expand Down Expand Up @@ -1958,7 +1958,7 @@ struct blk *copy(struct blk *hptr, int size)
{
register struct blk *hdr;
register unsigned sz;
register char *ptr;
register signed char *ptr;

all++;
nbytes += size;
Expand All @@ -1985,7 +1985,7 @@ struct blk *copy(struct blk *hptr, int size)

void sdump(char *s1, struct blk *hptr)
{
char *p;
signed char *p;
printf("%s %o rd %o wt %o beg %o last %o\n", s1, hptr, hptr->rd,
hptr->wt, hptr->beg, hptr->last);
p = hptr->beg;
Expand All @@ -1996,7 +1996,7 @@ void sdump(char *s1, struct blk *hptr)

void seekc(struct blk *hptr, int n)
{
char *nn, *p;
signed char *nn, *p;

nn = hptr->beg + n;
if (nn > hptr->last) {
Expand Down Expand Up @@ -2123,7 +2123,7 @@ void garbage(char *s)
void redef(struct blk *p)
{
register int offset;
register char *newp;
register signed char *newp;

if ((int) p->beg & 01) {
printf("odd ptr %o hdr %o\n", p->beg, p);
Expand Down
Loading