Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make USB uart separate from hardware UART #1060

Merged
merged 4 commits into from
Apr 5, 2024

Conversation

veremenko-y
Copy link
Contributor

Also make hardware UART fully blocking for kput/kprintf

Also make hardware UART fully blocking for kput/kprintf
@EtchedPixels
Copy link
Owner

-extern uint8_t progbase[USERMEM];
+extern char progbase[USERMEM];

This seems to be unrelated and strange ?

Rest looks ok but please try and use (void) not () for no arg functions. The PI compiler doesn't care but no some targets there is a difference between "no arguments" and "K&R style who knows arguments"

@veremenko-y
Copy link
Contributor Author

Rest looks ok but please try and use (void) not () for no arg functions. The PI compiler doesn't care but no some targets there is a difference between "no arguments" and "K&R style who knows arguments"

Ack. I'll go though the patch to ensure it doesn't happen again. Do you want me to add this to the CodingStyle.md? (which I realized I haven't read, but it does missing the foo(void)).

This seems to be unrelated and strange ?

This was part of fighting the compiler and conflicting types. I'll check this first and remove if unnecessary.

@veremenko-y
Copy link
Contributor Author

Both issues should be addressed now.

@EtchedPixels EtchedPixels merged commit b2b8244 into EtchedPixels:master Apr 5, 2024
13 checks passed
@EtchedPixels
Copy link
Owner

Thanks - merged

@veremenko-y veremenko-y deleted the pico_usb_uart branch April 15, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants