Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate input values to their lengths #1056

Closed
wants to merge 1 commit into from

Conversation

veremenko-y
Copy link
Contributor

Truncate input values in makeversion.c.
This prevents broken output of uname if values with exceeding length are suplied.

@EtchedPixels
Copy link
Owner

How are we getting broken lengths in the first place is my question ?

@veremenko-y
Copy link
Contributor Author

veremenko-y commented Apr 4, 2024

I came across it when I tried adding timestamp to the kernel build, so I can track when last I compiled the kernel on the PI.
As of now I don't think there's any code path that hits it. Feel free to close it at your discretion.

@EtchedPixels
Copy link
Owner

Ok probably better to do something in kernel/start.c lilke

#ifdef KERNEL_PRINT_ID
kputs(KERNEL_PRINT_ID);
#endif

@veremenko-y veremenko-y deleted the makeversion_fix branch April 15, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants