Skip to content

Conversation

knbhagat
Copy link
Contributor

@knbhagat knbhagat commented Sep 18, 2025

  1. Description:

Modified sharing level access on the hub-ai assistant

  1. Instructions for testing:

Related to https://devtopia.esri.com/dc/hub/issues/14115

  1. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  2. used semantic commit messages

  3. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  4. Updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

  5. These changes have been verified by QA using a ?uiVersion that includes a PR-Preview of this branch and the v_req label has been applied to the issue.

  6. OD-UI E2E tests pass against these changes using a ?uiVersion that includes a PR-Preview of this branch

*CRITICAL
If you are making a breaking change, make sure to add the BREAKING CHANGE comment in the merge commit message. If this is not done, semantic-release will not do the right thing.

If you find yourself in this position...

  1. open a PR to master with a trivial change - fix a linting problem or something.
  2. when you merge that, make sure you add the BREAKING CHANGE message in the merge commit.
  3. then run npm deprecate @esri/{package-name}@v{version-you-don't-want-out}

Copy link
Member

@dbouwman dbouwman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@DavidSpriggs DavidSpriggs merged commit 21888a9 into master Sep 26, 2025
2 checks passed
@DavidSpriggs DavidSpriggs deleted the t/14115-update-site-workspace-assistant-configuration branch September 26, 2025 18:54
esri-dcdev-2 pushed a commit that referenced this pull request Sep 26, 2025
# @esri/hub-common [20.12.0](https://github.com/Esri/hub.js/compare/@esri/[email protected]...@esri/[email protected]) (2025-09-26)

### Features

* **hub-common:** modified sharing level access on site sharing level ([#2011](#2011)) ([21888a9](21888a9))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants