Skip to content

Conversation

benstoltz
Copy link
Member

@benstoltz benstoltz commented Sep 18, 2025

  1. Description: Moves 3dtiles service type to maps collection from other collection

  2. Instructions for testing:

  3. Closes Issues: # (if appropriate)

  4. Updated meaningful TSDoc to methods including Parameters and Returns, see Documentation Guide

  5. used semantic commit messages

  6. PR title follows semantic commit format (CRITICAL if the title is not in a semantic format, the release automation will not run!)

  7. Updated peerDependencies as needed. CRITICAL our automated release system can not be counted on to update peerDependencies so we must do it manually in our PRs when needed. See the updating peerDependencies section of the release instructions for more details.

  8. These changes have been verified by QA using a ?uiVersion that includes a PR-Preview of this branch and the v_req label has been applied to the issue.

  9. OD-UI E2E tests pass against these changes using a ?uiVersion that includes a PR-Preview of this branch

*CRITICAL
If you are making a breaking change, make sure to add the BREAKING CHANGE comment in the merge commit message. If this is not done, semantic-release will not do the right thing.

If you find yourself in this position...

  1. open a PR to master with a trivial change - fix a linting problem or something.
  2. when you merge that, make sure you add the BREAKING CHANGE message in the merge commit.
  3. then run npm deprecate @esri/{package-name}@v{version-you-don't-want-out}

@benstoltz benstoltz requested a review from tomwayson September 18, 2025 13:46
Copy link

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Sep 22, 2025
@benstoltz benstoltz removed the Stale Stale issue - update or it will be closed label Sep 22, 2025
Copy link

There hasn't been any activity on this pull request in the past 3 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. If you want this PR to never become stale, please apply the "Draft" label.

@github-actions github-actions bot added the Stale Stale issue - update or it will be closed label Sep 26, 2025
@benstoltz benstoltz removed the Stale Stale issue - update or it will be closed label Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants