This repository has been archived by the owner on Oct 6, 2023. It is now read-only.
add a start to take labels expressions from esri. #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related: Esri/esri-leaflet#916 |
jgravois
reviewed
Oct 22, 2019
Comment on lines
+8
to
+16
| scaleToZoom: function (scaleValue) { | ||
| if (scaleValue >= 500000000) { | ||
| return 0; | ||
| } | ||
| if (scaleValue >= 250000000) { | ||
| return 1; | ||
| } | ||
| if (scaleValue >= 150000000) { | ||
| return 2; |
There was a problem hiding this comment.
this function could be collapsed with a little more math.
Esri/esri-leaflet#426 (comment)
Nice! I've marked this PR as Work In Progress. Some things I am thinking of:
What do you think? |
|
I don't work at @Esri anymore but that sounds like a good plan to me. if no one swoops in to help you land your work here, you could always publish it on your own. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've made a starting point for adding labels to the esri-leaflet-renderers.
I see this is requested by: ynunokawa/L.esri.WebMap#74 .
I wanted this feature also for my own project.
There is more work to be done in this area. For example only center and topright position is supported now. The expression language is far more complicated than currently implemented.
This is a breaking change. Some users did probably work arround the missing label feature themself.
So a major version bump is required in my opinion.
Kind regards,
Pieter