Skip to content

Conversation

hud10837
Copy link
Collaborator

@hud10837 hud10837 commented Sep 10, 2025

Related to issue: https://devtopia.esri.com/runtime/kotlin/issues/6421

Description:

Adds support for including tests that are located in the kotlin SDK repo into the toolkit. This allows us to use internal dependencies such as mockingjay in the toolkit tests. This PR adds just an example of how to do it in the template test, as well as an implementation for featureforms to add mockingjay as a dependency.

Note: tests in the sdk repo are included additively, so internal tests do not preclude public tests. The internal tests are visible while working in the toolkit repo using the Android view in the project hierarchy. Additionally, dependencies and all other gradle considerations should still be done on the toolkit side.

Summary of changes:

  • Update the project build.gradle to include a new property which records the location of toolkit tests in the sdk repo which sits side-by-side with the toolkit
  • Update the template build.gradle and featureforms build.gradle to make use of this functionality

Pre-merge Checklist

@hud10837 hud10837 changed the base branch from main to v.next September 10, 2025 13:45
@hud10837 hud10837 requested a review from kaushikrw September 10, 2025 13:52
Copy link
Collaborator

@kaushikrw kaushikrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hud10837 This works quite well! I tested it with a dummy test and was easy to setup. I just have some minor cosmetic feedback below

@hud10837 hud10837 marked this pull request as ready for review September 15, 2025 10:57
@hud10837 hud10837 requested a review from kaushikrw September 16, 2025 15:33
@hud10837 hud10837 self-assigned this Sep 16, 2025
Copy link
Collaborator

@kaushikrw kaushikrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hud10837 hud10837 requested a review from gunt0001 September 17, 2025 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants