-
Notifications
You must be signed in to change notification settings - Fork 8
Hud10837/toolkit tests in sdk #980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hud10837
wants to merge
19
commits into
v.next
Choose a base branch
from
hud10837/toolkit-tests-in-sdk
base: v.next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in-toolkit into hud10837/toolkit-tests-in-sdk
kaushikrw
reviewed
Sep 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hud10837 This works quite well! I tested it with a dummy test and was easy to setup. I just have some minor cosmetic feedback below
kaushikrw
approved these changes
Sep 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: https://devtopia.esri.com/runtime/kotlin/issues/6421
Description:
Adds support for including tests that are located in the kotlin SDK repo into the toolkit. This allows us to use internal dependencies such as mockingjay in the toolkit tests. This PR adds just an example of how to do it in the template test, as well as an implementation for featureforms to add mockingjay as a dependency.
Note: tests in the sdk repo are included additively, so internal tests do not preclude public tests. The internal tests are visible while working in the toolkit repo using the
Android
view in the project hierarchy. Additionally, dependencies and all other gradle considerations should still be done on the toolkit side.Summary of changes:
Pre-merge Checklist