-
Notifications
You must be signed in to change notification settings - Fork 8
Merge Feature branches/forms into v.next
#1003
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update how attachment states are created * remove onExpressionsEvaluated
* enable and fix edge-to-edge * use safedrawing * fix select feature dialog height * add loading callout when identifying layers
* refactor navigation to support nested destinations * add paging, symbology display for features * change feature list title * add association creation * add asset type selection * add final screens * optimize imports and extract strings * update association creation logic * extract strings * updated ignored api classes * Add filter/search functionality * revert logic to determine query result size from paging params * add ignore for "com.arcgismaps.toolkit.featureforms.internal.utils.ComposableSingletons\$SearchBarKt" * remove paging * CR : Puneet * rename routes * rename more routes * move filtering logic to the composable from viewModel * update SearchBar UI * abstract filter logic to viewmodel * update doc * address code review comments * update padding * don't clear sources filter in selectSource --------- Co-authored-by: Kaushik Meesala <[email protected]>
puneet-pdx
approved these changes
Oct 16, 2025
sorenoid
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue: #kotlin/6733
Description:
This PR merges the latest featureform dev into v.next. This also introduces the infra for networking mocking from #969
Summary of major changes:
FeatureForm: Microapp add folder browsing #964Pre-merge Checklist