(DO NOT MERGE) Carlos/open street map sample #1606
Draft
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: William Bohrmann <[email protected]> Co-authored-by: Carlos Gutierrez <[email protected]>
…ndroid (#1589) Co-authored-by: William Bohrmann <[email protected]>
…#1599) Co-authored-by: Carlos Gutierrez <[email protected]>
… platforms (#1603) Co-authored-by: Carlos Gutierrez <[email protected]>
…de deprecation notice
|
@williambohrmann3 Corrections made - ready for re-review. |
| @@ -28,6 +28,8 @@ When the sample opens, it will automatically display the map with the OpenStreet | |||
|
|
|||
| ## Additional information | |||
|
|
|||
| ArcGIS Maps SDK OpenStreetMap Styles is deprecated and will be retired in 2030. The last release will be ArcGIS Maps SDK 200.8, in Q3 2025. For more information, see the deprecation announcement. | |||
There was a problem hiding this comment.
Suggested change
| ArcGIS Maps SDK OpenStreetMap Styles is deprecated and will be retired in 2030. The last release will be ArcGIS Maps SDK 200.8, in Q3 2025. For more information, see the deprecation announcement. | |
| OpenStreetMap basemap styles has been deprecated with the release of ArcGIS Maps SDK 200.8. |
There was a problem hiding this comment.
@pMaske @mbranscomb thoughts on this wording?
Co-authored-by: Morten Nielsen <[email protected]>
…de deprecation notice
…arcgis-maps-sdk-dotnet-samples into Carlos/OpenStreetMapSample pulling from remote branch
This reverts commit 3d0748c.
|
@williambohrmann3 Corrected all of the weird branch issues, looks like its good now. |
williambohrmann3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is for OpenStreetMap layer in Layers category. OpenStreetMap is the qualified proper noun for the project, instead of "Open Street Map" (with whitespace).
NOTE: This naming convention was already the case for .NET, just needed to go in and fix the style checker and add the deprecation alert in the readme files.
Type of change
Platforms tested on
Checklist