Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local custom data source data from sample viewer #1275

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented Aug 2, 2023

Description

Now that the data for the Add custom dynamic entity data source sample is hosted on ArcGIS online we can remove it from the sample app to be downloaded on demand.

Type of change

  • Other enhancement

Platforms tested on

  • WPF .NET 6
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files

Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested on Mac/iOS

public partial class AddCustomDynamicEntityDataSource
{
// Path to AIS Traffic Data json file.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your choice: "Vessel AIS Traffic Data" would more closely match name of online item and could be slightly clearer.

@duffh duffh merged commit e5de5c7 into v.next Aug 3, 2023
2 checks passed
@duffh duffh deleted the hduff/remove-custom-data-source-data-from-app-bundle branch August 3, 2023 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants