Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update samples using sketch editor to use geometry editor #1274

Merged
merged 6 commits into from
Aug 4, 2023

Conversation

duffh
Copy link
Collaborator

@duffh duffh commented Aug 1, 2023

Description

As sketch editor is being replaced by geometry editor we are replacing sketch editor usage in samples with geometry editor.

Type of change

  • Other enhancement

Platforms tested on

  • WPF .NET 6
  • WPF Framework
  • WinUI
  • MAUI WinUI
  • MAUI Android
  • MAUI iOS
  • MAUI MacCatalyst

Checklist

  • Self-review of changes
  • All changes work as expected on all affected platforms
  • There are no warnings related to changes
  • Code is commented and follows .NET conventions and standards
  • Codemaid and XAML styler extensions have been run on every changed file
  • No unrelated changes have been made to any other code or project files

@duffh duffh marked this pull request as ready for review August 1, 2023 14:26
@duffh duffh requested a review from jnery-yy August 1, 2023 15:18
Copy link

@jnery-yy jnery-yy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this started @duffh. I just have few suggestions.

I think how you have it now works too. Only suggesting:

  • projection necessary
  • nameof() syntax
  • unnecessary TaskCanceledException catch
  • unnecessary Stop when Start is about to be called again
  • if double tapped gesture is needed, we can still call Stop there

@duffh duffh requested a review from jnery-yy August 1, 2023 21:38
Copy link

@jnery-yy jnery-yy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 thanks for staying on top of deprecation warnings :)

Copy link
Collaborator

@williambohrmann3 williambohrmann3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad you were able to fix the pre-existing issues!

@duffh duffh merged commit 843f94c into v.next Aug 4, 2023
2 checks passed
@duffh duffh deleted the hduff/update-samples-using-sketch-editor branch August 4, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants