Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Sample: Add custom dynamic entity data source #1269

Merged
merged 21 commits into from
Jul 27, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8,400 changes: 8,400 additions & 0 deletions src/MAUI/Maui.Samples/Resources/Raw/AIS_MarineCadastre_SelectedVessels_v2.json

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="utf-8" ?>
<ContentPage x:Class="ArcGIS.Samples.AddCustomDynamicEntityDataSource.AddCustomDynamicEntityDataSource"
xmlns="http://schemas.microsoft.com/dotnet/2021/maui"
xmlns:x="http://schemas.microsoft.com/winfx/2009/xaml"
xmlns:esriUI="clr-namespace:Esri.ArcGISRuntime.Maui;assembly=Esri.ArcGISRuntime.Maui">
<Grid>
<esriUI:MapView x:Name="MyMapView" GeoViewTapped="GeoViewTapped" />
</Grid>
</ContentPage>
Original file line number Diff line number Diff line change
@@ -0,0 +1,121 @@
// Copyright 2023 Esri.
//
// Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License.
// You may obtain a copy of the License at: http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific
// language governing permissions and limitations under the License.

using Esri.ArcGISRuntime.ArcGISServices;
using Esri.ArcGISRuntime.Data;
using Esri.ArcGISRuntime.Mapping;
using Esri.ArcGISRuntime.Mapping.Labeling;
using Esri.ArcGISRuntime.RealTime;
using Esri.ArcGISRuntime.Symbology;
using Esri.ArcGISRuntime.UI;

namespace ArcGIS.Samples.AddCustomDynamicEntityDataSource
{
[ArcGIS.Samples.Shared.Attributes.Sample(
"Add custom dynamic entity data source",
"Layers",
"Display data from a custom dynamic entity data source using a dynamic entity layer. ",
"")]
public partial class AddCustomDynamicEntityDataSource
{
public AddCustomDynamicEntityDataSource()
{
InitializeComponent();
Initialize();
}

private void Initialize()
{
// Create a new map with the navigation basemap style.
MyMapView.Map = new Map(BasemapStyle.ArcGISNavigation);

// Set the initial viewpoint.
MyMapView.SetViewpoint(new Viewpoint(47.984036751327544, -123.65671327050406, 3000000));

// Create a new custom file source.
// This takes the path to the desired data source and the field name that will be used as the entity id and the delay between each observation that is processed.
// In this example we are using a json file as our custom data source.
// This field name should be a unique identifier for each entity.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In our design discussions, there was some confusion about the field name and the field value. Probably best to be explicit about the field value being the unique identifier.

// Adjusting the value for the delay will change the speed at which the entities and their observations are displayed.
var customSource = new CustomFileSource("AIS_MarineCadastre_SelectedVessels_v2.json", "MMSI", TimeSpan.FromMilliseconds(10));

// Create the dynamic entity layer using the custom data source.
var dynamicEntityLayer = new DynamicEntityLayer(customSource);

// Set up the track display properties.
SetupTrackDisplayProperties(dynamicEntityLayer);

// Set up the dynamic entity labeling.
SetupLabeling(dynamicEntityLayer);

// Add the dynamic entity layer to the map.
MyMapView.Map.OperationalLayers.Add(dynamicEntityLayer);
}

private void SetupTrackDisplayProperties(DynamicEntityLayer layer)
{
// Set up the track display properties, these properties will be used to configure the appearance of the track line and previous observations.
layer.TrackDisplayProperties.ShowPreviousObservations = true;
layer.TrackDisplayProperties.ShowTrackLine = true;
layer.TrackDisplayProperties.MaximumObservations = 20;
}

private void SetupLabeling(DynamicEntityLayer layer)
{
// Define the label expression to be used, in this case we will use the "VesselName" for each of the dynamic entities.
var simpleLabelExpression = new SimpleLabelExpression("[VesselName]");

// Set the text symbol color and size for the labels.
var labelSymbol = new TextSymbol() { Color = System.Drawing.Color.Red, Size = 12d };

// Set the label position.
var labelDef = new LabelDefinition(simpleLabelExpression, labelSymbol) { Placement = LabelingPlacement.PointAboveCenter };

// Add the label definition to the dynamic entity layer and enable labels.
layer.LabelDefinitions.Add(labelDef);
layer.LabelsEnabled = true;
}

private async void GeoViewTapped(object sender, Esri.ArcGISRuntime.Maui.GeoViewInputEventArgs e)
{
e.Handled = true;
try
{
MyMapView.DismissCallout();

// If no dynamic entity layer is present in the map, return.
var layer = MyMapView.Map?.OperationalLayers.OfType<DynamicEntityLayer>().FirstOrDefault();
if (layer is null) return;

// Identify the tapped observation.
IdentifyLayerResult results = await MyMapView.IdentifyLayerAsync(layer, e.Position, 2d, false);
DynamicEntityObservation observation = results.GeoElements.FirstOrDefault() as DynamicEntityObservation;
if (observation is null) return;

// Get the dynamic entity from the observation.
var dynamicEntity = observation.GetDynamicEntity();
if (dynamicEntity is null) return;

// The standard callout takes care of moving when the dynamic entity changes.
var calloutDef = new CalloutDefinition(dynamicEntity);
if (layer.Renderer?.GetSymbol(dynamicEntity) is Symbol symbol)
{
await calloutDef.SetIconFromSymbolAsync(symbol);
}

// Show the callout for the tapped dynamic entity.
MyMapView.ShowCalloutForGeoElement(dynamicEntity, e.Position, calloutDef);
}
catch (Exception ex)
{
await DisplayAlert("Error identifying dynamic entity.", ex.Message, "Ok");
}
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,217 @@
using Esri.ArcGISRuntime.Data;
using Esri.ArcGISRuntime.Geometry;
using Esri.ArcGISRuntime.RealTime;
using System.Diagnostics;
using System.Text.Json;


namespace ArcGIS.Samples.AddCustomDynamicEntityDataSource
{
public class CustomFileSource : DynamicEntityDataSource
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should rename this to something more specific to the data (i.e. SimulatedAisDataSource or something similar). Then the sample could be less generic and more tightly coupled with the data. The ability to create data specific custom data sources is a reasonable message to give to users as well.

{
// Hold a reference to the file stream reader, the process task, and the cancellation token source.
private Task? _processTask;
private StreamReader? _streamReader;
private CancellationTokenSource? _cancellationTokenSource;
private TaskCompletionSource<object?>? _pauseTask;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not actively controlling playback of the file, I think we can remove _pauseTask altogether to simplify the code.


public CustomFileSource(string filePath, string entityIdField, TimeSpan delay)
{
FilePath = filePath;
EntityIdField = entityIdField;
Delay = delay;
}

#region Properties

// Expose the file path, entity ID field, and delay length as properties.
public string FilePath { get; }
public string EntityIdField { get; }
public TimeSpan Delay { get; }
public SpatialReference SpatialReference { get; set; } = SpatialReferences.Wgs84;

#endregion

protected override async Task<DynamicEntityDataSourceInfo> OnLoadAsync()
{
// Derive schema from the first row in the custom data source.
var fields = await InferSchemaAsync();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To simplify, we can just return a static list of fields instead of inferring the schema.


// Open the file for processing.
Stream stream = await FileSystem.OpenAppPackageFileAsync(FilePath);
_streamReader = new StreamReader(stream);

// Create a new DynamicEntityDataSourceInfo using the entity ID field and the fields derived from the attributes of each observation in the custom data source.
return new DynamicEntityDataSourceInfo(EntityIdField, fields) { SpatialReference = SpatialReferences.Wgs84 };
}

protected override Task OnConnectAsync(CancellationToken cancellationToken)
{
// On connecting to the custom data source begin processing the file.
_cancellationTokenSource = new();
_processTask = Task.Run(() => ObservationProcessLoopAsync(), _cancellationTokenSource.Token);
return Task.CompletedTask;
}

protected override async Task OnDisconnectAsync()
{
// On disconnecting from the custom data source, stop processing the file.
_cancellationTokenSource?.Cancel();
_pauseTask?.TrySetResult(null);

if (_processTask is not null) await _processTask;

_cancellationTokenSource = null;
_pauseTask = null;
_processTask = null;
}

private async Task ObservationProcessLoopAsync()
{
try
{
while (!_cancellationTokenSource!.IsCancellationRequested)
{
// If the pause task is not null, wait for it to complete before processing the next observation.
if (_pauseTask is not null)
{
await _pauseTask.Task;
}

// Process the next observation.
var processed = await ProcessNextObservation();

// If the observation was not processed, continue to the next observation.
if (!processed) continue;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed an End-of-Stream bug here (my bug - sorry). We should check _streamReader.EndOfStream and break out of the loop, or we'll run forever.


// If there is no delay, yield to the UI thread otherwise delay for the specified amount of time.
if (Delay == TimeSpan.Zero)
{
await Task.Yield();
}
else
{
await Task.Delay(Delay, _cancellationTokenSource.Token);
}
}
}
catch (Exception ex)
{
Debug.WriteLine(ex.ToString());
}
}

private async Task<bool> ProcessNextObservation()
{
// If we cannot read from the file, throw an exception.
if (_streamReader is null)
{
throw new ArgumentNullException("File stream not available.");
}

// Read the next observation from the file.
var json = await _streamReader.ReadLineAsync();
if (string.IsNullOrEmpty(json)) return false;

try
{
// Parse the observation from the file using the JsonGeoElementParser.
// This will return a graphic holding a MapPoint and a dictionary of attributes.
var graphic = JsonGeoElementParser.ParseGraphicFromJson(json);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can find a different way to do the parsing so we're not deserializing into a Graphic. I don't think we want to do that in a sample as DynamicEntityObservation and Graphic are not related (except that they both derive from GeoElement) and we wouldn't want to confuse someone.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Parsing to a standard JsonElement might be the ticket here. If we do that, we can probably get rid of the whole JsonGeoElement which is kind of confusing in a sample.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, that simplifies things a lot.

if (graphic?.Geometry is not MapPoint point) return false;

// Check to see if the spatial reference of the observation matches the spatial reference of the custom data source.
// If not, project the observation to the spatial reference of the custom data source.
if (point.SpatialReference?.Equals(SpatialReference) != true)
{
graphic.Geometry = GeometryEngine.Project(graphic.Geometry, SpatialReference);
}

// Add the observation to the dynamic entity layer for presentation on the map.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be careful the separation of the data source and the layer. Here we're adding an observation to the data source which can happen whether or not the data source is contained by a layer or not.

AddObservation(graphic.Geometry, graphic.Attributes);
return true;
}
catch (Exception ex)
{
Debug.WriteLine(ex.ToString());
return false;
}
}

private async Task<List<Field>> InferSchemaAsync()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'd opt for removing this altogether and just using a static list of fields that's tied to the data.

{
var fields = new List<Field>();

try
{
// Load the file we are using for our custom data source.
using var stream = await FileSystem.OpenAppPackageFileAsync(FilePath);
if (stream != null)
{
using var streamReader = new StreamReader(stream);

// Read the first line of the file.
var json = await streamReader.ReadLineAsync();

// If the first line is empty the scheme cannot be inferred.
if (string.IsNullOrEmpty(json))
{
throw new InvalidOperationException("Could not infer schema (empty json line at the start of the file).");
}

// Parse the first line of the file using the JsonGeoElementParser.
var jsonGeoElement = JsonSerializer.Deserialize<JsonGeoElementParser.JsonGeoElement>(json);

// If no attributes are present in the JsonGeoElement, the scheme cannot be inferred.
if (jsonGeoElement?.attributes is null)
{
throw new InvalidOperationException("Could not infer schema (parsing error).");
}

// Loop through the attributes in the JsonGeoElement and create fields for each attribute based on the field type and length.
foreach (var attr in jsonGeoElement.attributes)
{
// Infer the field type and length from the attribute value.
var fieldType = Type.GetTypeCode(attr.Value?.GetType()) switch
{
TypeCode.Boolean or TypeCode.Int16 or TypeCode.UInt16 or TypeCode.Single => FieldType.Int16,
TypeCode.Int32 or TypeCode.UInt32 => FieldType.Int32,
TypeCode.DateTime => FieldType.Date,
TypeCode.Decimal => FieldType.Float32,
TypeCode.Double or TypeCode.Int64 or TypeCode.UInt64 => FieldType.Float64,
_ => FieldType.Text,
};

var length = Type.GetTypeCode(attr.Value?.GetType()) switch
{
TypeCode.Boolean or TypeCode.Int16 or TypeCode.UInt16 or TypeCode.Single => 2,
TypeCode.Int32 or TypeCode.UInt32 or TypeCode.Decimal => 4,
TypeCode.Double or TypeCode.Int64 or TypeCode.UInt64 => 8,
_ => 256,
};

// Create a field from the attribute type, name and length and add it to the list of fields.
var field = new Field(fieldType, attr.Key, string.Empty, length);
fields.Add(field);
}
}
}
catch (Exception ex)
{
Debug.WriteLine(ex.ToString());
}

return fields;
}

public async Task StepAsync()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need this method if we're not managing file playback.

{
bool processed;
do
{
processed = await ProcessNextObservation();
}
while (!processed);
}
}
}
Loading