chore!: new Advz constructor, Advz use u32 instead of usize #539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #463
Advz::new
no longer takemultiplicity
arg. Instead we choosemultiplicity
for the caller. (Currently we setmulitiplicity
to 1, issue ADVZ intelligent choice of multiplicity #534 .) Also, reorder the arg list.Advz::with_multiplicity
does whatAdvz::new
used to do.multiplicity
as requested by @mrainpayload_chunk_size
->recovery_threshold
. Much clearer IMO.usize
tou32
. Lots of uglyas usize
everywhere, but at least these conversions are safe. Dammit, Rust.gpu-vid
feature. @mrain we might need you to check the build withgpu-vid
.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pending
section inCHANGELOG.md
Files changed
in the GitHub PR explorer