Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add BLS signature short pk variant #378

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Sep 28, 2023

Description

Major changes include:

  • move current bls_over_bn254 impl to bls_over_bn254::min_sig
  • add bls_over_bn254::min_pk module

closes: #373


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (main)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

@alxiong alxiong self-assigned this Sep 28, 2023
@mrain
Copy link
Contributor

mrain commented Oct 9, 2023

Is this still working? We may still want a short pk version for a smaller stake table.
cc @alxiong

@alxiong
Copy link
Contributor Author

alxiong commented Oct 10, 2023

I see! I paused this previously, but I will keep working on it this week. Thanks for reminding me! @mrain

@chancharles92
Copy link
Contributor

I see! I paused this previously, but I will keep working on it this week. Thanks for reminding me! @mrain

Thanks @alxiong ! Let me know when it's ready.

@alxiong alxiong added crypto Crypto team tasks (PM purpose) and removed crypto Crypto team tasks (PM purpose) labels Nov 11, 2023
@alxiong alxiong added the crypto Crypto team tasks (PM purpose) label Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Crypto team tasks (PM purpose)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[primitives] Add "short pk" variant of BLS signature
3 participants