address comments

merkle_tree/src/internal.rs

@@ -7,7 +7,7 @@
 use super::{
     DigestAlgorithm, Element, Index, LookupResult, MerkleCommitment, NodeValue, ToTraversalPath,
 };
-use crate::{errors::MerkleTreeError, prelude::MerkleTree, VerificationResult};
+use crate::{errors::MerkleTreeError, prelude::MerkleTree, VerificationResult, FAILED, SUCCESS};
 use alloc::sync::Arc;
 use ark_serialize::{CanonicalDeserialize, CanonicalSerialize};
 use ark_std::{borrow::Borrow, format, iter::Peekable, string::ToString, vec, vec::Vec};
@@ -197,9 +197,9 @@ where
             },
         )?;
     if computed_root == commitment.digest() {
-        Ok(Ok(()))
+        Ok(SUCCESS)
     } else {
-        Ok(Err(()))
+        Ok(FAILED)
     }
 }
 

merkle_tree/src/lib.rs

@@ -41,6 +41,10 @@ use serde::{Deserialize, Serialize};
 
 /// Glorified bool type
 pub(crate) type VerificationResult = Result<(), ()>;
+/// Glorified true
+pub const SUCCESS: VerificationResult = Ok(());
+/// Glorified false
+pub const FAILED: VerificationResult = Err(());
 
 #[derive(Clone, Copy, PartialEq, Eq, Debug, Hash)]
 /// The result of querying at an index in the tree

merkle_tree/src/light_weight.rs

@@ -110,7 +110,7 @@ where
 #[cfg(test)]
 mod mt_tests {
     use crate::{
-        internal::{MerkleNode, MerkleTreeProof},
+        internal::MerkleNode,
         prelude::{RescueLightWeightMerkleTree, RescueMerkleTree},
         *,
     };