Repository navigation
Shrink tool payload - #756
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The net10-only CLI change breaks verified repo scripts that hard-code net8.0 output paths and should be accompanied by corresponding updates or an explicit compatibility decision.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR reduces the .NET tool payload / build matrix by consolidating the SqlAnalyzer CLI to a single target framework and aligning the analyzer test project to the same runtime.
Changes:
- Change
tools/SqlAnalyzerClifrom multi-targeting (net8.0;net10.0) tonet10.0only. - Change
test/TSQLAnalyzer.Testsfromnet8.0tonet10.0.
File summaries
| File | Description |
|---|---|
| tools/SqlAnalyzerCli/SqlAnalyzerCli.csproj | Drops multi-targeting so the packaged CLI/tool builds only for net10.0. |
| test/TSQLAnalyzer.Tests/TSQLAnalyzer.Tests.csproj | Updates the test project to run on net10.0 to match the newer runtime baseline. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
There was a problem hiding this comment.
🟡 Changes recommended
The updated test project file still contains a non-boolean <IsPackable>string</IsPackable> value, which should be corrected to an explicit boolean to avoid unintended SDK behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Lite
No description provided.