Skip to content

fix build warnings - #48

Merged
ErikEJ merged 1 commit into
mainfrom
build-warnings
Sep 29, 2025
Merged

ErikEJ merged 1 commit into
mainfrom
build-warnings

Conversation

@ErikEJ

@ErikEJ ErikEJ commented Sep 29, 2025

Copy link
Copy Markdown
Owner

fixes #47

Copilot AI review requested due to automatic review settings September 29, 2025 08:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request addresses build warnings in the codebase by improving nullable reference type annotations and code analysis compliance. The changes focus on making the code more robust by properly handling null values and suppressing specific code analysis rules where appropriate.

  • Add nullable reference type annotations to fix compiler warnings
  • Initialize properties with non-null values or null-forgiving operators
  • Add code analysis suppressions for acceptable design patterns
  • Handle potential null returns with fallback values

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/Vsix/Dialogs/PickTablesDialog.xaml.cs Added blank line for formatting
src/DacFXToolLib/TableListBuilder.cs Made databaseModel field nullable
src/DacFXToolLib/Routines/SqlServerRoutineModelFactory.cs Added null-forgiving operators and null coalescing for string properties
src/DacFXToolLib/Routines/Extensions/SqlServerRoutineServiceCollectionExtensions.cs Made reporter parameters nullable
src/DacFXToolLib/HumanizerPluralizer.cs Removed null-conditional operators
src/DacFXToolLib/GlobalSuppressions.cs Added code analysis suppression for generic list exposure
src/DacFXToolLib/DatabaseModelToMermaid.cs Added null-forgiving operator for foreignKey.Name
src/DacFXTool/Program.cs Made schemas array nullable and used null-coalescing with empty array
src/Contracts/GlobalSuppressions.cs Added code analysis suppression for generic list exposure
src/Contracts/DatabaseType.cs Added pragma directives to suppress FlagsAttribute warning

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread src/DacFXToolLib/HumanizerPluralizer.cs
Comment thread src/DacFXToolLib/HumanizerPluralizer.cs
@ErikEJ
ErikEJ merged commit d0d554b into main Sep 29, 2025
1 check passed
@ErikEJ
ErikEJ deleted the build-warnings branch April 15, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix build warning from analyzers

2 participants