Skip to content

Some final touches on mege script feature - needs smoke testing - #102

Merged
ErikEJ merged 3 commits into
mainfrom
final-merge
Nov 9, 2025
Merged

ErikEJ merged 3 commits into
mainfrom
final-merge

Conversation

@ErikEJ

@ErikEJ ErikEJ commented Nov 9, 2025

Copy link
Copy Markdown
Owner

related to #93

Copilot AI review requested due to automatic review settings November 9, 2025 08:26

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR makes final refinements to the merge script feature for generating table data scripts. The changes update UI text for clarity, integrate the generated scripts with the project's post-deployment process, and enhance the script output with helpful documentation comments.

  • Updated button text from "Script Seed Data" to "Script Table Data" for better clarity
  • Added automatic integration of generated scripts into the project's post-deployment configuration
  • Enhanced generated merge scripts with preamble documentation and command text comments

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.

File Description
src/Vsix/VSCommandTable.vsct Updated button text to "Script Table Data" for improved clarity
src/Vsix/Handlers/SeedHandler.cs Added logic to automatically append generated scripts to postdeploy.sql file
src/DacFXToolLib/MergeGenerator.cs Enhanced generated scripts with documentation preamble and command text; added null check
README.md Added documentation for the new Script Table Data feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Vsix/VSCommandTable.vsct
Comment thread src/DacFXToolLib/MergeGenerator.cs Outdated
Comment thread src/DacFXToolLib/MergeGenerator.cs Outdated
Comment thread src/DacFXToolLib/MergeGenerator.cs Outdated
Comment thread src/Vsix/Handlers/SeedHandler.cs
Comment thread src/Vsix/Handlers/SeedHandler.cs Outdated
@ErikEJ ErikEJ closed this Nov 9, 2025
@ErikEJ ErikEJ reopened this Nov 9, 2025
@ErikEJ

ErikEJ commented Nov 9, 2025

Copy link
Copy Markdown
Owner Author

@copilot Create a PR to add Copilot instructions

Copilot AI commented Nov 9, 2025

Copy link
Copy Markdown
Contributor

@ErikEJ I've opened a new pull request, #103, to work on those changes. Once the pull request is ready, I'll request review from you.

@ErikEJ
ErikEJ requested a review from Copilot November 9, 2025 08:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/Vsix/Handlers/SeedHandler.cs Outdated
@ErikEJ
ErikEJ merged commit 4732006 into main Nov 9, 2025
1 check passed
@ErikEJ
ErikEJ deleted the final-merge branch April 15, 2026 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants