Skip to content

feat: Bootstrap config files #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025
Merged

feat: Bootstrap config files #127

merged 2 commits into from
Mar 20, 2025

Conversation

typotter
Copy link
Collaborator

@typotter typotter commented Mar 18, 2025

feat: ConfigurationWire formatted files for bootstrapping clients.

Tested in common#251
Generation script: common#248

Created files using the bootstrap-config script

# Basic flags bootstrap
yarn bootstrap-config --key non-specified \
--sdk node-server \
--base-url https://us-central1-eppo-qa.cloudfunctions.net/serveGitHubRacTestFile/api \
--output ../sdk-test-data/ufc/bootstrap-flags-v1.json

# Obfuscated flags v1
yarn bootstrap-config --key bandits-key \
--sdk android \
--base-url https://us-central1-eppo-qa.cloudfunctions.net/serveGitHubRacTestFile/api \
--output ../sdk-test-data/ufc/bootstrap-flags-v1-obfuscated.json 

# Bandits
yarn bootstrap-config --key bandits-key \
--sdk node-server \
--base-url https://us-central1-eppo-qa.cloudfunctions.net/serveGitHubRacTestFile/api \
--output ../sdk-test-data/ufc/bootstrap-bandit-flags-v1.json 

@greghuels
Copy link
Contributor

@typotter Where is the boostrap-config script you used?

@typotter
Copy link
Collaborator Author

typotter commented Mar 19, 2025

@typotter Where is the boostrap-config script you used?

It is here @greghuels :
Eppo-exp/js-sdk-common#248

Copy link
Collaborator

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me though I suggest removing "bootstrap" from the name—these configurations are useful beside initial bootstrapping

@typotter
Copy link
Collaborator Author

Looks good to me though I suggest removing "bootstrap" from the name—these configurations are useful beside initial bootstrapping

Agreed. Dropped boostrap prefix. These file now parallel the ufc directory

@typotter typotter merged commit 0dcce4f into main Mar 20, 2025
4 checks passed
@typotter typotter deleted the tp/bootstrap-config branch March 20, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants