fix: simplify isObfuscated messaging
#253
Conversation
…ange level to info
src/client/eppo-client.ts
Outdated
| this.expectObfuscated = isObfuscated; | ||
|
|
||
| if (isObfuscated !== undefined) { | ||
| logger.info( |
There was a problem hiding this comment.
minor: given this log is infrequent, I think warn is justified
There was a problem hiding this comment.
I had warn here originally. Then I figured that the developer would see a warning at build time if they're using the deprecated methods/params. Changing this to a warn would essentially produce a redundant warning to the devs, and possibly annoy their log monitors until we release the new version with the field&method removed.
There was a problem hiding this comment.
I still think that warn is OK here as otherwise nobody is going to see it 🙂 But I don't feel very strongly about it, so feel free to disagree and ignore
There was a problem hiding this comment.
hm. let's do warn and we'll revisit if a customer experiences issues with the volume of warnings (which we'll hopefully obviate but cutting a new major release)
Motivation and Context
The deprecation of
isObfuscatedled to the desire to emit a warning when the SDK may be acting out of expected vis a vis obfuscated state of the config. The implementation left a lot to be desired and had some bugs.Changes
isObfuscatedisObfuscatedCacheand warning on mismatchEppoClientParametersto have newoverridesfield and restore use ofEppoClientParameterstype in constructor. This was broken in feat: add local override functionality #184