Skip to content

chore(ci): fix CI not triggering on sdk-test-data update #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 14, 2025

Conversation

rasendubi
Copy link
Collaborator

Example sdk-test-data update not triggering CI: #237

Note that it triggered Dart SDK checks but not other SDKs. This happens because sdk-test-data is a submodule, so it's treated as a file (not directory) during checking for updates.

This PR removes /** from all sdk-test-data patterns (same as in dart.yml), so it should trigger the rest of checks.

@rasendubi rasendubi requested a review from schmit March 14, 2025 10:00
Copy link

changeset-bot bot commented Mar 14, 2025

⚠️ No Changeset found

Latest commit: 03294af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@schmit schmit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@rasendubi rasendubi merged commit 26cbe84 into main Mar 14, 2025
@rasendubi rasendubi deleted the chore-sdk-test-data-ci branch March 14, 2025 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants