chore: Make AssignmentCacheKey properties public #55
Conversation
| public var subjectKey: String | ||
| public var flagKey: String | ||
| public var allocationKey: String | ||
| public var variationKey: String |
There was a problem hiding this comment.
Looking at this definition, it seems off? In a sense that it is not a real cache key (but rather a “cache entry”)—the user has to re-implement CacheKey/CacheValue which are still hidden and it may be rather tricky
If we want to make assignment cache public / implementable by users, I would argue that it should work on either CacheKey+CacheValue, or it should accept the whole assignment event (so users have the freedom of what they want to cache on). But at this point, it becomes rather rudimentary and it's probably easier for users to implement a wrapper around their own logger, which is rather easy to do
There was a problem hiding this comment.
You're definitely right about that - ok before making this public I think it makes sense to tidy up the interface by splitting it out.
motivation
Customers are unable to provide their own implementation of an
AssignmentCachebecause the properties ofAssignmentCacheKeyare not publicdescription
Make properties of
AssignmentCacheKeypublic.