-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
infra: change base url to https://fscdn.eppo.cloud
and route requests to /edge/assignments
#16
base: main
Are you sure you want to change the base?
Conversation
… to /edge/assignments
@@ -39,7 +39,7 @@ void main() { | |||
); | |||
|
|||
// Verify the flags | |||
expect(config.flags.length, equals(6)); | |||
expect(config.flags.length, equals(7)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new test got added: Eppo-exp/sdk-test-data@a59d066
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may want to just check that the length is greater than some reasonable amount, or that the loaded flag keys contain at least the key of the flags checked below.
https://fscdn.eppo.cloud
and route requests to /edge/assignments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments for you to take or leave as you see fit.
@@ -0,0 +1,8 @@ | |||
# Motivation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
# Changes | ||
<!-- List the changes made in this pull request. Be concise but specific. --> | ||
|
||
# Testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a Documentation section as well when I've made changes to these templates in other SDKs. Since our SDKs are publicly used, most changes have a DX impact.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we keep most of our docs in that docs repo what do you put in a documentation
section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
usually just a link to linear ticket for updating the docs, or a link to a PR where the docs have been updated (or are wip) or n/a. Just something to demonstrate that updating the docs is tracked.
@@ -1,5 +1,9 @@ | |||
# Changelog | |||
|
|||
## 1.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨ Nice to start a changelog from the start of a project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub.dev
strongly encourages and yells at me when publish without a corresponding change
@@ -31,7 +31,7 @@ class EppoApiClient { | |||
String? baseUrl, | |||
Duration? requestTimeout, | |||
EppoHttpClient? httpClient, | |||
}) : baseUrl = baseUrl ?? precomputedBaseUrl, | |||
}) : baseUrl = baseUrl ?? eppoBaseUrl, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@@ -39,7 +39,7 @@ void main() { | |||
); | |||
|
|||
// Verify the flags | |||
expect(config.flags.length, equals(6)); | |||
expect(config.flags.length, equals(7)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
may want to just check that the length is greater than some reasonable amount, or that the loaded flag keys contain at least the key of the flags checked below.
Co-authored-by: Tyler Potter <[email protected]>
Motivation
Migrating routing to use the
fscdn.eppo.cloud
domain. The new canonical for this request isfscdn.eppo.cloud/edge/assignments
Changes
https://fscdn.eppo.cloud
Testing
The example program runs by fetching production configuration and it is success at returning non-default values: