Fix rdi_decompressed_size_from_parsed to account for 8-byte alignment padding#801
Open
portbuster1337 wants to merge 1 commit into
Open
Conversation
… padding The previous formula raw_data_size + sum(unpacked_size - encoded_size) assumes sections are packed tightly in the decompressed buffer, but rdi_decompress_parsed aligns each section's data to 8-byte boundaries. This could cause a heap buffer overflow when the decompressed buffer is allocated based on the underestimated size. Compute the exact decompressed layout size by replicating the same alignment logic used in rdi_decompress_parsed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
rdi_decompressed_size_from_parsedcomputes the decompressed size as:This formula assumes sections are packed tightly in the decompressed buffer. However,
rdi_decompress_parsedaligns each section's data to 8-byte boundaries with padding, so the actual decompressed buffer is larger than the formula predicts. When callers (radbin.c, dbg_info.c) use this function to allocate the output buffer, the buffer may be too small, causing a heap buffer overflow.Fix
Replicate the exact layout computation from
rdi_decompress_parsedto compute the correct decompressed size: