Skip to content

fix(auth): infer RS256 from RSA+sig when JWK alg is missing #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AdvenRanises wants to merge 1 commit into
base: main
Choose a base branch
from
+16 −1
Open

fix(auth): infer RS256 from RSA+sig when JWK alg is missing #65

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion lore-server/src/auth/jwk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ pub enum JWKServiceError {
DecodingError(#[from] jsonwebtoken::errors::Error),
#[error("Key for kid not found")]
NotFound,
#[error("JWK with kid '{kid}' is missing the 'alg' field and cannot be inferred")]
MissingAlgorithm { kid: String },
}

#[async_trait]
Expand Down Expand Up @@ -143,7 +145,20 @@ impl JwkServiceImpl {
let algorithm = jwk
.common
.key_algorithm
.ok_or(JWKServiceError::InternalError)?;
.or({
// RFC 7517: alg is OPTIONAL. Infer from key type when absent.
match (&jwk.algorithm, jwk.common.public_key_use.as_ref()) {
(jsonwebtoken::jwk::AlgorithmParameters::RSA(_), Some(jsonwebtoken::jwk::PublicKeyUse::Signature)) => {
Some(jsonwebtoken::jwk::KeyAlgorithm::RS256)
}
_ => None,
}
})
.ok_or_else(|| {
let kid_str = jwk.common.key_id.clone().unwrap_or_default();
warn!(kid = %kid_str, "JWK missing 'alg' field and cannot be inferred from key type");
JWKServiceError::MissingAlgorithm { kid: kid_str }
})?;
let algorithm = jsonwebtoken::Algorithm::from_str(&algorithm.to_string())
.map_err(JWKServiceError::DecodingError)?;

Expand Down